search

sclorg / container-common-scripts

Apache License 2.0
21 stars 45 forks source link

regression in 'ct_clean_app_images' #326

Closed phracek closed 1 year ago

phracek commented 1 year ago

See TF logs: https://artifacts.dev.testing-farm.io/1aeb5586-979f-482e-92cd-b4e6ae053b91/

Tests itself PASSED:

It looks like we have a big regression here:

+ echo ===============================================
===============================================
+ echo 'Test cases results:'
Test cases results:
+ echo

+ echo ' [PASSED] for '\''postgresql-container_tests'\'' run_container_creation_tests (00:00:33)
 [PASSED] for '\''postgresql-container_tests'\'' run_general_tests (00:01:01)
 [PASSED] for '\''postgresql-container_tests'\'' run_change_password_test (00:00:06)
 [PASSED] for '\''postgresql-container_tests'\'' run_replication_test (00:00:08)
 [PASSED] for '\''postgresql-container_tests'\'' run_master_restart_test (00:00:12)
 [PASSED] for '\''postgresql-container_tests'\'' run_doc_test (00:00:01)
 [PASSED] for '\''postgresql-container_tests'\'' run_s2i_test (00:00:17)
 [PASSED] for '\''postgresql-container_tests'\'' run_test_cfg_hook (00:00:10)
 [PASSED] for '\''postgresql-container_tests'\'' run_s2i_bake_data_test (00:00:18)
 [PASSED] for '\''postgresql-container_tests'\'' run_s2i_enable_ssl_test (00:00:10)
 [PASSED] for '\''postgresql-container_tests'\'' run_upgrade_test (00:00:00)
 [PASSED] for '\''postgresql-container_tests'\'' run_migration_test (00:00:00)
 [PASSED] for '\''postgresql-container_tests'\'' run_pgaudit_test (00:00:03)
 [PASSED] for 'postgresql-container_tests' run_container_creation_tests (00:00:33)
 [PASSED] for 'postgresql-container_tests' run_general_tests (00:01:01)
 [PASSED] for 'postgresql-container_tests' run_change_password_test (00:00:06)
 [PASSED] for 'postgresql-container_tests' run_replication_test (00:00:08)
 [PASSED] for 'postgresql-container_tests' run_master_restart_test (00:00:12)
 [PASSED] for 'postgresql-container_tests' run_doc_test (00:00:01)
 [PASSED] for 'postgresql-container_tests' run_s2i_test (00:00:17)
 [PASSED] for 'postgresql-container_tests' run_test_cfg_hook (00:00:10)
 [PASSED] for 'postgresql-container_tests' run_s2i_bake_data_test (00:00:18)
 [PASSED] for 'postgresql-container_tests' run_s2i_enable_ssl_test (00:00:10)
 [PASSED] for 'postgresql-container_tests' run_upgrade_test (00:00:00)
 [PASSED] for 'postgresql-container_tests' run_migration_test (00:00:00)
 [PASSED] for 'postgresql-container_tests' run_pgaudit_test (00:00:03)

+ '[' -n 0 ']'
+ '[' 0 -eq 0 ']'
+ echo 'Tests for quay.io/sclorg/postgresql-13-c9s:1 succeeded.'
Tests for quay.io/sclorg/postgresql-13-c9s:1 succeeded.
+ ct_clean_app_images
+ local image
+ [[ ! -d /tmp/APP_ID_FILE_DIR_12249 ]]
+ echo 'Examining image ID files in $APP_ID_FILE_DIR=/tmp/APP_ID_FILE_DIR_12249'
Examining image ID files in $APP_ID_FILE_DIR=/tmp/APP_ID_FILE_DIR_12249
+ for file in "${APP_ID_FILE_DIR:?}"/*
++ cat /tmp/APP_ID_FILE_DIR_12249/17729
+ image=815a90074eae106533a87ca4cc82035b4ed562d86c76209ecb9c7b119fbba020
+ docker inspect 815a90074eae106533a87ca4cc82035b4ed562d86c76209ecb9c7b119fbba020
++ docker ps -q -a -f ancestor=815a90074eae106533a87ca4cc82035b4ed562d86c76209ecb9c7b119fbba020
+ containers=396b96cb6d47
+ [[ -z 396b96cb6d47 ]]
+ docker rm -f 396b96cb6d47
396b96cb6d47
+ docker rmi -f 815a90074eae106533a87ca4cc82035b4ed562d86c76209ecb9c7b119fbba020
Untagged: quay.io/sclorg/postgresql-13-c9s:1-bake_35173334fx
Deleted: 815a90074eae106533a87ca4cc82035b4ed562d86c76209ecb9c7b119fbba020
Deleted: 1739602a791bb59030ab777ee040dcfd2582f84780e5deaead5d9c39508d7a5a
Deleted: 7e8a6884af7242c74a2663f9d7b6a6f01b8aed07908346c4f0c3c48e1cbf1dfe
Deleted: 47b060a08684507421704cbe32fd4a584284948eef2133eeac9be1471b95d63b
Deleted: dbfcd28a0c36b891b28a7b3f907036493d9aa1450ced156538e5471aa0ca618c
Deleted: 86b82ea245064cc0a920bbbcc3764283536313707a060133ef5419ec19f74e7b
Deleted: a0c00eb96e5680be7bf781b53ae51ba60ba4081772d78990b3c6799ab9905107
Deleted: 9741091306b4a0da7bcc6e1740436aa598ea195e54abdeeee34cf894cb9f069d
Deleted: b454d32aff0031a0d07f484c5ed8056ad2b435bf1dae200a69b635bd6a31a231
+ for file in "${APP_ID_FILE_DIR:?}"/*
++ cat /tmp/APP_ID_FILE_DIR_12249/25014
+ image=a12adca9adb3ee7fd5ad369011e96b95e5da766c30c7de1f0b112c1fc96176a2
+ docker inspect a12adca9adb3ee7fd5ad369011e96b95e5da766c30c7de1f0b112c1fc96176a2
++ docker ps -q -a -f ancestor=a12adca9adb3ee7fd5ad369011e96b95e5da766c30c7de1f0b112c1fc96176a2
+ containers=aa69c4c41b2a
+ [[ -z aa69c4c41b2a ]]
+ docker rm -f aa69c4c41b2a
aa69c4c41b2a
+ docker rmi -f a12adca9adb3ee7fd5ad369011e96b95e5da766c30c7de1f0b112c1fc96176a2
Untagged: quay.io/sclorg/postgresql-13-c9s:1-testapp_ny5nte0mny
Deleted: a12adca9adb3ee7fd5ad369011e96b95e5da766c30c7de1f0b112c1fc96176a2
Deleted: 8b3b24d3e1829adab381026dd18fdbcbfbdd3c94cd240f3ef72eca05ea880bee
Deleted: 64ab105667fc40da92ea2f932040956e89a1940abfe377094b1bcfa79e70e392
Deleted: 9dbba2c2db4ed2cfbea77d37b448c2e00df5cdab162644c1a48593a5f7e8b2a5
Deleted: 7aa2941bf776293a359683dc1981722d0017af1b5c97fd97ba716a39b7c0f31a
Deleted: 7580f590ab387c705ef00d02f7956bd3fc604a6ba7ef4bdeae3372511c111bb5
Deleted: 378cc01399b36220794ca3e85e9c0311414693ea026a086a4cf7d7b0fabf00a4
+ for file in "${APP_ID_FILE_DIR:?}"/*
++ cat /tmp/APP_ID_FILE_DIR_12249/30161
+ image=574f771ba119a8750886357985fb2d197b0686160d1c5db4d26c773e33cf675e
+ docker inspect 574f771ba119a8750886357985fb2d197b0686160d1c5db4d26c773e33cf675e
++ docker ps -q -a -f ancestor=574f771ba119a8750886357985fb2d197b0686160d1c5db4d26c773e33cf675e
+ containers=adba9a7941ed
+ [[ -z adba9a7941ed ]]
+ docker rm -f adba9a7941ed
adba9a7941ed
+ docker rmi -f 574f771ba119a8750886357985fb2d197b0686160d1c5db4d26c773e33cf675e
Untagged: quay.io/sclorg/postgresql-13-c9s:1-ssl_hft3eu2f2p
Deleted: 574f771ba119a8750886357985fb2d197b0686160d1c5db4d26c773e33cf675e
Deleted: b834dee95dfdd64620040713e97765e90aee178d1d50131064346fc135c50ff5
Deleted: 6245133cff2bc4495e7ef196005b5695551f7c07500493b6a222f56c32f929c8
Deleted: 53af2bf397033126dc0ed08e1ff45643cfd19e2fa43cf9dc675a679993e8f3a8
Deleted: 55c408b5d7770bf3ae32d606c107cf1f73c1afed8db3f941de7f88933659df4a
Deleted: 618801e1846259609b91a43a60f310fa0c00c720d07d89649f362c2ade0cb516
Deleted: 135b915d7fb2833018a7f80ce05a5b88a54ed251522926e12f72fcd97bdb930c
+ rm -fr /tmp/APP_ID_FILE_DIR_12249
+ [[ -z /tmp/tmp.yThUCIAH8Xpostgresql_test_cidfiles ]]
+ echo 'Examining CID files in $CID_FILE_DIR=/tmp/tmp.yThUCIAH8Xpostgresql_test_cidfiles'
Examining CID files in $CID_FILE_DIR=/tmp/tmp.yThUCIAH8Xpostgresql_test_cidfiles
+ for cid_file in "$CID_FILE_DIR"/*
+ '[' -f /tmp/tmp.yThUCIAH8Xpostgresql_test_cidfiles/admin ']'
+ local container
++ cat /tmp/tmp.yThUCIAH8Xpostgresql_test_cidfiles/admin
+ container=cd62f73162982463bcfd16d82785d36081c841cd81ab60e0c4ab354dd41eb113
+ rm /tmp/tmp.yThUCIAH8Xpostgresql_test_cidfiles/admin
+ ct_container_exists cd62f73162982463bcfd16d82785d36081c841cd81ab60e0c4ab354dd41eb113
+ local exists
++ docker ps -q -a -f id=cd62f73162982463bcfd16d82785d36081c841cd81ab60e0c4ab354dd41eb113
+ exists=cd62f7316298
+ '[' -n cd62f7316298 ']'
+ echo 'Stopping and removing container cd62f73162982463bcfd16d82785d36081c841cd81ab60e0c4ab354dd41eb113...'
Stopping and removing container cd62f73162982463bcfd16d82785d36081c841cd81ab60e0c4ab354dd41eb113...
+ ct_container_running cd62f73162982463bcfd16d82785d36081c841cd81ab60e0c4ab354dd41eb113
+ local running
++ docker inspect -f '{{.State.Running}}' cd62f73162982463bcfd16d82785d36081c841cd81ab60e0c4ab354dd41eb113
+ running=true
+ '[' true = true ']'
+ docker stop cd62f73162982463bcfd16d82785d36081c841cd81ab60e0c4ab354dd41eb113
cd62f73162982463bcfd16d82785d36081c841cd81ab60e0c4ab354dd41eb113
++ docker inspect -f '{{.State.ExitCode}}' cd62f73162982463bcfd16d82785d36081c841cd81ab60e0c4ab354dd41eb113
+ exit_status=0
+ '[' 0 '!=' 0 ']'
+ docker rm -v cd62f73162982463bcfd16d82785d36081c841cd81ab60e0c4ab354dd41eb113
Error: remove /tmp/tmp.yThUCIAH8Xpostgresql_test_cidfiles/admin: no such file or directory
zmiklank commented 1 year ago

This seem to be quite a strange error to me.

+ docker rm -v cd62f73162982463bcfd16d82785d36081c841cd81ab60e0c4ab354dd41eb113
Error: remove /tmp/tmp.yThUCIAH8Xpostgresql_test_cidfiles/admin: no such file or director

It seems, that docker rm itself generated this error. Error outputs of rm and rmdir are different. However I am not sure, what has docker rm to do with CID file.

Does this error happen repeatedly?

zmiklank commented 1 year ago

It seems, that docker rm removes also the cidfile, if the container was created by docker run --cidfile=xxx ....