sclorg / container-common-scripts

Apache License 2.0
20 stars 45 forks source link

Test log output improvements needed #328

Closed zmiklank closed 1 year ago

zmiklank commented 1 year ago

Since we clean after tests now more thoroughly, the cleaning process generates more logs.

Problem is, that first the test results are printed and just after the logs from cleanup.

This should be switched in order to maintain log readability.

phracek commented 1 year ago

I don't follow your comment. Can you please add a code snipped?

zmiklank commented 1 year ago

Yes. This is current output:

===============================================
Test cases results:

 [PASSED] for 'app' test_run_app_application (00:00:01)
 [PASSED] for 'app' test_s2i_usage (00:00:01)
 [PASSED] for 'app' test_scl_usage (00:00:02)
 [PASSED] for 'app' test_connection (00:00:00)
 [PASSED] for 'app' test_docker_run_usage (00:00:00)
 [PASSED] for 'app' test_scl_variables_in_dockerfile (00:00:00)
 [PASSED] for 'app' test_npm_functionality (00:00:06)
 [PASSED] for 'app' test_check_build_using_dockerfile (00:00:46)
 [PASSED] for 'app' test_nodemon_removed (00:00:01)
 [PASSED] for 'app' test_npm_cache_cleared (00:00:01)
 [PASSED] for 'app' test_npm_tmp_cleared (00:00:02)
 [PASSED] for 'app' kill_test_application (00:00:00)
 [PASSED] for 'app' test_dev_mode_true_development (00:00:02)
 [PASSED] for 'app' test_dev_mode_false_production (00:00:02)
 [PASSED] for 'node_env_development' test_run_app_application (00:00:00)
 [PASSED] for 'node_env_development' test_connection (00:00:02)
 [PASSED] for 'node_env_development' test_nodemon_present (00:00:01)
 [PASSED] for 'node_env_development' test_npm_cache_exists (00:00:01)
 [PASSED] for 'node_env_development' kill_test_application (00:00:01)
 [PASSED] for 'node_env_development' test_dev_mode_true_development (00:00:02)
 [PASSED] for 'node_env_development' test_dev_mode_false_development (00:00:02)
 [PASSED] for 'dev_mode' test_run_app_application (00:00:00)
 [PASSED] for 'dev_mode' test_connection (00:00:02)
 [PASSED] for 'dev_mode' test_nodemon_present (00:00:01)
 [PASSED] for 'dev_mode' test_npm_cache_exists (00:00:01)
 [PASSED] for 'dev_mode' kill_test_application (00:00:00)
 [PASSED] for 'dev_mode' test_dev_mode_true_development (00:00:02)
 [PASSED] for 'dev_mode' test_dev_mode_false_production (00:00:02)
 [PASSED] for 'hw' test_safe_logging (00:00:00)
 [PASSED] for 'hw' test_run_hw_application (00:00:01)
 [PASSED] for 'hw' test_incremental_build (00:00:45)
 [PASSED] for 'hw' test_build_express_webapp (00:00:29)
 [PASSED] for 'clients' test_client_express (00:00:56)
 [PASSED] for 'clients' test_client_pino (00:06:27)
 [PASSED] for 'clients' test_client_prom (00:02:14)
 [PASSED] for 'clients' test_client_opossum (00:01:17)
 [PASSED] for 'clients' test_client_kube (00:00:51)
 [PASSED] for 'binary' test_run_binary_application (00:02:58)

Tests for ubi8/nodejs-16:1 succeeded.
Examining image ID files in $APP_ID_FILE_DIR=/tmp/tmp.ijze9rEi4N
149f68077e3769bbc0891329e3f988daefaa6b4ac9e48852a0a81dfd947f598a
84a98834589ccc2908547f15779d298b8c383c0764739e57b284d53d98602958
4db70ebf86b4f91f9ac6b649539f41f3b9f5136ad596edfe480cbe2a1e251124
d75d6dd3a458d990dff3ba9199459753d11128bf2cdb3abd8c268bc3d0402215
319f2e59fac1a407cbe487559aae03df61a00811f5f4024ba8e95744034fe452
8f5ef9c06385bb40a1b84fc58bd441fa3fdde20cad260100153d815ddacee212
878bf0babd58fa6ea846f67419ecde6a44b30c21e717b75d4620392e459b3d5c
b07432b1ca196b95d2465a0b0e732df46dff7c378e5781eaa6a64d3eab1444ff
7d845b630664c1a4be3b60f274ba3e193458995a5a79cd17e47f5c59b9c0637b
Deleted: 8ff1dd5735e3e30116acf76586f0fbf4ecdca549b2839f4fb2886d2c43b2e771
ae9ca66fe46c9d2094966b3844592576fa0cb787f01756f62024618bf42b80f0
d3c7a718b44829d8a5323d4245fc8d68685096e03363a1a1e74f0380d5388063
0cbfa0d7e7128ac5d5a4f696c2e4912d491a7f0aaea2c44c0c62160527835b45
f7a693832cdb1d933e7938b8020623ff0f7f97957495f6e64d7ca0659c1e9d5e
0fc6efd1be636169e2ddb70baaac2960d80c1c3bcc8f07d2c2798d332545a633
fa1f13f607f9cb5470a7d740978a0c58bc5f3e1ccec4e776c9638e638e6561b9
a17f48555994f9d448c37a9ddcfae1c02cc71b6d9058858dd1e20663049e8cc7
47d33b798db64427ff1066317e9264f85c097cfae9f98dbbe94a1a7fee3f5328
Deleted: 3b4e512c519fc71e326be482393c65083f9c647b5fdfb1519a6563834e5a1080
775d407f1f0478ac4268e5c4a6514a83a6927c0b9eef22640275c137dc7a1bd7
863f209ad66ec2b1a973bb541a917f0af3bd47a4b52f2739a4c3269d7eac4080
3a8d37491672dcb9ded78fcf7b829e53f79de39dc3944aa80aee868d23df99b1
fb66dc047f42091270d34906396a2f48064ca1bfc3f26b2e06a76578db359037
a3904ae381dcfc9624d4dbaf00abbb4f23697e1a319d0c8c903fa0f4ef4e0774
de38553078246da247b78203f593631cade12656b669398d528c5259143eab3f
6a1e329213f7013c44548e4d9e8f218de36096f70ef9adf1a5c78eb3b6e4da09
f0bacf707343e4caed5e34cda077f62b0f5f2a38cc7ae2b77486f7a1a839d49e
Untagged: localhost/ubi8/nodejs-16:1-testexpress-webapp
Deleted: 1a9013033b2f6c217c41e370e8d0ec45588d2f8623a2001ad3a0d61819b106ae
4763156c874af8558a79dee0c41560704741b236342c5cb709100b94cee8e3da
95e354f9aa52e28b397a08b33c1f9c9c650a3a2e01818ef1a390beb36942a47c
b09498f4ac43d24dbfeea1a346b80600debb8cb2867c12967fd5f85b960818e5
5a75151e2ce2b84107d1e9a17c6680dd4953e3950bb9ca7e5c519e5fa4622d4b
c64dc6ab7e3555a4fe21ef2afc377dad299bc2ebeb3f75b092b4b96dcfbd7130
627e57f90f89d946ec15620f1a872529ec4cfb2b38c6b4a13f9cc9fe7369645d
35a7dae16aaebe3cd07b22654a2901ee10f2eff973d3275a9db8b1be708c15a5
4ff8c83526d24a32c99a4a529bae47737d67960ddfaa4c85043caf5eba8dc182
cce9d66e05323d76f9a3156141effd8fc4e466fe915520127542b59a6e895c68
Untagged: localhost/ubi8/nodejs-16:1-express
Deleted: b7bdf75734d17fd10a03f47d01254d38aed8bc9dcd3470ec57c8822b64feef4b
c8efb0b007292b40dd15c433001ac4f1123ee22027b3f172c418d09a6f57e869
2d463eb35dd0d23e87c2ef08ae2fc0f581fd9d5daf2c0b3a0b7bfb9c5fddccad
cd870a23601dddd27209978c5de348b93baa1badf24d52616c9cd6b37ca72998
20d1f7ab2e13cc2d49287b8c6401bc1046390078c1357969facdd7e164ed4837
b8454efe442f551ef7883c21d269ced1b4cbbe74657c6d33477043e3bd648629
50a8d65e9bb4ccc4b8e93bcc8ed0ef95898f3eeea66d39b5e34e793708a6ec79
e181fe2f6692233ed1b2756278547178ea1f81242fa3010af0e7d8721c5827d7
b94a75dfda109e58461c464ca75b887a1072cb248065dbbe2bdfc4113fd6e35f
b06708d7733d587f33bdbe1635f6c89cfb6cc6db5e858f0f084a831b148a8dc6
Deleted: ddb9dd33eccbc6176c47ac8acc4acdaaaf85459062bc97e85cd827077ff7f5ac
c83a63c2e47d83218186106b50589c98d1ffe2066d5773cf6701128f8ecee6f0
4e389cbaae50ea83e271dac29d113872ea602cc74533335ff9d5f0f3977e86d4
4b9eac6d873adc8e5dd63ad73fb4d2bcbfe3d89bd2e19f6bc913d645f6bc0df1
111d5ff29c0719169d2b581eff4470b0f5dd9911f88931072cc8cada913d61ae
ebb45c7beb68afa88c9751f13a80c5b5586c3d073c9c0d35373fcdbddc87f7f3
ce0bc1ebfd550fbfe28808077428a587653f22307ef93f7a2faf25b7137d5b8b
ea95514fcb845a7d463a06038c2cdb23ae3d1bf5519dff716e3b907d0e2cae2f
861900a7c24685d752ab8743deaaeb584cc48c86558a155f81d2efbacc377ede
c22c9b7939c49d5f6f856f6ff604a254c786efd0951308336b1b63970884a4ec
Untagged: localhost/ubi8/nodejs-16:1-prom-client
Deleted: b42bfe0001e7f180a45c6869b4343a37ba0713e5b91710f1acadf11e1712741b
055940bbeed6c03c7e30a3f7b19179a109f5627d42a4ee6431e249d4a3610f9d
362759d8455d39d0b93d8dcc7cf1b3a670a14e97c7f1eb4ae0abd0d78f2a51c4
7bec952edd72913c4693ea60f7fe3ec381d985cf7ea5e73ec721b283aff9ba60
69b17890a22f7d883ad4ce17e91c7540058c8c3232cdc76114e923b949e726e5
ed3e9d7ab0e81f2129a9b08b345235a09dd4fb112dea54d5c6de2b28464f0865
7d521fa4ce8e8cf48d77ca3d3172b641d40f195bee489be215a64ba9215eb90c
ee8929380f75fbe2382fdd17af2516f31d0a81d72012f9dfe775b514603fc12c
d50cc681e5dc58ba746aad25cb7962e544c93e965ecd28da6c7e2a456eddf51e
Untagged: localhost/ubi8/nodejs-16:1-testbinary
Deleted: 36b39a4d2cfb05d8a240258f9f028ff8ca07ee58f86271d137f9027a09e0f303
108b6cc6a7c737a1e5e2550de0dd14ef98c169835b51a21d6c0fbc8ea2cbdca9
8d0d3cc54cb7c5428cc2d7784aebcb98b59bdbbab7fa2ca5be2eae0ee45d6ffd
e7bb72c567aed85b1908f6cf502270452a73ad60bcb5decf48995dda2ea0eb2a
b1fbb23415557ebe40d3d0123962262e10dca4efcaba5d18a3ff0bcaea806565
adf37b05ca9201b2c400446d7daef3048e8eeca08e9e5646616bfee7a648b348
d03a822d926d47bdf5f22b885643fa603020b7fe81c29962c0e08089c24642e7
596a2ed3fe1ef8b68f234dec7b328e1348b80afbbb3fac9fe115f69212b5aafc
6e71ef449941ba78f64c9258890ce4513ad19cd50413de14cf4520461b1dc4f5
8efaf3b9ead8af8b4149708b4cb71237d03c088e2551b459955aad17420c7227
3e8712ca368496b4b37f5d5ae74932dc625170cf31d83f569dc489c95c56b307
0b9a9ea40fa43f8bc55019def3714faaa9151669ed35ca0243ea7ac7c5c7bf2b
Untagged: localhost/ubi8/nodejs-16:1-testapp
Deleted: 51b9c186cee2b45dba54b1d5f0db04f60a3289cce78bea6e1a190c44bd075709
1620209306663d9e42b35106d5c723846fc6b236308402bc9822d3a3fbdba779
2fb57def2280cd5d61ec35849b639a583cae0ca463ce57e67c196752e1b0ec57
ca635dd8886721e01b7f1fa4f53d2add9e635353b9310fe40a20c5c07ea616ce
fc0e5a2aaebc751c16111329dd8248bfd61690526fc8688c937c9ac8463e4fa9
16df9b01f582076496e889903510aa565a388ca86e478ea40412d9053d991a18
3fdaa252e125c012e4a4a55d6df95d0447ec7f55c8162e18df1fcb010792b80a
339b3cc923d515a855670135ec9156ed7674f7d233e5e7cbf99481951b0b5c4d
f2733d1249cfa57e312e252985c32143cc23499b096e3208e357d6c98dc62950
Deleted: 3e87fe686038d44dabf71ea2ae085b506678777307f70bf0c45766cec081a565
b1e7da2d336bf910d0f41e14cf0fab6c746a2e36b5e790ccdfa1a71f164c3201
07ea4e683bf138677400452140aa45fbb51e0e2f735eff4d2bf7dc0ef92500d4
4b16b45e17914335ea9571c5f46bfbbd5cd007282bfbf3a02b2681c455acab27
65dbf210448618f337b07e36633e20a8c668924a6d566af04810ec2d6d7cb5e5
7abf96e2ad940ffa1a9b6bbfc4b2f441f89891b892e9c4554e5abaa9d61335a4
e1cda4845ee89da0c957014a5df03a6ff75750dc3f681d5b9ca85a85c6525f75
9ab12c26a7e79312d8016320e0fced2e9d1cace0bd199d2f22dbaf45488fddda
6d004da1df29e2b919fa14ceb7e0978f55c162fbd3d428953f866e9e78d43e86
2b59813acefdb43ef40b259972527f94e1cb471dd85de38c3139d1b035aa18c9
Untagged: localhost/ubi8/nodejs-16:1-pino
Deleted: bbca2743a15a44f8551a928425cafd9ad5bf9df544802b071023905729a4dbe5
d722ff93dfb36310135c40a2438630120fd559ee672495f2e4e0e4f1361203ae
95b612fb9eb427cf8944f3fc46128b899f4b765d7e2e3e7dd2e10e0d0fe72969
bc23cad0909c869b508e2d20e398fed1605337fcd431f615f314851c723ad79a
4f9a1ed85bf48ef0e03a60746643dc4dec10ee88ea48765671630344a494a8bc
9c53586cd412044debadd374d0211cfbe0e783d1d0812d769b71c79b6a15e6be
3723268d81cef399bbddbb5da4d14c53688f30e369039308268e0777eb881aaf
f410970ac73ea58ee085ec403f2cd431aaa1597e440c053cfe63f0569f48be47
31e879dd4932a808211f6ddb836119720e55af773feff41a39cb5259daa5e563
2e0bc35a02eebbb6ea5f778b5e848886527276ffc15be28c2e09f953450b4881
67748b297766219f2ea6e64c5f1bf6e41067740ab90cee6c5d6c9f4386c6fddf
346eeefda220e66c4811158ad7b46656bb0a576ca666e7628ce397278fac601d
9800e1f16aff61ada2e3f99c02a5f4e1db491157809bb0951e662861ee4258c4
Untagged: localhost/ubi8/nodejs-16:1-testhw
Deleted: 09b0e14c184bf6f0fea837a3ee80ceb8f085a23be343a11ff8255ef5de2957d6
3ccfbf7c08250ed4f2e3cc786a85a83a6a207d336648b4a626d1e2a6b4fb9a61
e8c9a9047f91aeb882b1443c20afa16ffbeb90b6de143ffb786e46988ea37b72
4dcaedc0cea9348f715a6873a22fb3f76d25800b4ee15aefb6e9ffb5d3474788
3b5a4f66b6ce60aea46bc80f651c9e57860536335c4bc046bfbe4da62242ed75
699f3a98e7c6d580fe119ff72117a92a4dfb226c8939998f2046c333bbd72f4d
fdfeebe2a5d27d88d1a279688efb9f88d7ed2dc3729f3a900050aa7eefed0d66
f35a9f525446c0a4a90f1ea0537af24a81016080c31700428e06cddab22b0d36
305887e4b7d31fbaf5805341c7bc68aebed575ddede1674f03ea49d846c82915
bad7d035deb5320bdaf7694973b8cd6c5e15da32a4ef1ced63c72f1a52702a93
Untagged: localhost/ubi8/nodejs-16:1-kube-service-bindings
Deleted: cd5a48cb0e74e9d70057eee83d5fb6d6be0ed9f798cd3f4def429a34db76c11e
99f329bf2649adee4fa6ccf6ab8b06fe8308497c04f5d6ec940cdf80550568fd
44e53e5412d29a9ebfab1d9d07d8a17e7a1294651a658fccd287c5c9295883c5
69c266e396de4778021074d074cd2906cc51aaa4114ce21ed9270aa82cd50328
2c16ae4f7cff1fa25784326820b163fa784ff85ba37d0d052f5a79362866589b
f4004a10a22261eb8f01c808bc794e07ecea9484ad57c2116a8ec2494e3a697d
79430680030563a827b1cd9038591d13a636ce52fe059ee0d4d51d45bde4bea4
785bc43c7c738ea62a6dc5c8c3f9c34f734400cf9d33b14e81f6db6d88c9eda1
e45e755e91b34c319e237a3ed4887741c958b24af4cc2f913ff27616df7589bf
2fca183fba1de3a73da120e41759e3dba8fa134ee81c32727959061bfdcc97d6
Untagged: localhost/ubi8/nodejs-16:1-opossum
Deleted: ae49f41346b7239d118bbe8b9ff649486ba975431a6dc24a55de56a2317ea0f1
Examining CID files in $CID_FILE_DIR=/tmp/tmp.QKTl1ZvK43
Shared connection to 10.31.11.173 closed.

You have you scroll a lot in order to get to the results. We should I think put the status on the end of the log. But this is not necessarry, it is only nice to have.

zmiklank commented 1 year ago

PR https://github.com/sclorg/container-common-scripts/pull/338 is fixing this.