add debugging trap on error to scripts with exit on err enabled

sclorg / container-common-scripts

Apache License 2.0

21 stars 45 forks source link

add debugging trap on error to scripts with exit on err enabled #341

Closed zmiklank closed 1 year ago

zmiklank commented 1 year ago

Resolves: https://github.com/sclorg/container-common-scripts/issues/286

zmiklank commented 1 year ago

[test]

zmiklank commented 1 year ago

test errors are not related to this PR. But at least we can see there, that trap on ERR works ;).

zmiklank commented 1 year ago

Everything LGTM. Thanks. Only nitpick. I would add there a note or comment what -E means. So the user should not Google it ;)

I know, but this info can be easily gathered from man sh. I am not sure if it is efficient to have comments for such things here. But that's subjective opinion, of course.