search

sclorg / container-common-scripts

Apache License 2.0
21 stars 45 forks source link

Remove set -e and add to the end FAILED message #369

Closed phracek closed 1 month ago

phracek commented 1 month ago

Remove set -e and add to the end FAILED message in case test failed.

zmiklank commented 1 month ago

And please, check the shellcheck output.

phracek commented 1 month ago

[test]

zmiklank commented 1 month ago

However, I think this PR does not really solve the problem you want to solve. That would require to remove exit on error from build.sh and tag.sh. However, that is not safe to do, as all of testsuites on our container repos rely on that. And if any image is not even buildable - as it the case in this PR - I see no reason to try to run rest of the tests anyway, even for other versions, as unbuildable image is a big problem by itself.

phracek commented 1 month ago

However, I think this PR does not really solve the problem you want to solve. That would require to remove exit on error from build.sh and tag.sh. However, that is not safe to do, as all of testsuites on our container repos rely on that. And if any image is not even buildable - as it the case in this PR - I see no reason to try to run rest of the tests anyway, even for other versions, as unbuildable image is a big problem by itself.

Currently, in case of build.sh and tag.gs failed then test is not run anymore. Because in both script there is present set -e where it should be. In case one test has failed, then the next version has to be tested. This pull request does not belong to building and tagging. Only for tests.