search

sclorg / container-workflow-tool

MIT License
1 stars 9 forks source link

Symlinks to symlinks are not evaluated properly during downstream sync #31

Open pkubatrh opened 3 years ago

pkubatrh commented 3 years ago

Recently hit this issue when syncing with https://github.com/sclorg/s2i-nodejs-container/pull/269

Seems like cwt is doing the right thing in re-evaluing the target of the symlink multiple times, but always uses the target that is present in upstream for the original symlink for the eventual copy:

rh_cwt.main.distgit - DEBUG: looking for dangling symlink nodejs-14-minimal/test/check_imagestreams.py (that points to nodejs-14-minimal/test/../../test/check_imagestreams.py)
rh_cwt.main.distgit - DEBUG: unlink nodejs-14-minimal/test/check_imagestreams.py
rh_cwt.main.distgit - DEBUG: cp upstreams/nodejs/14-minimal/test/../../test/check_imagestreams.py nodejs-14-minimal/test/check_imagestreams.py
rh_cwt.main.distgit - DEBUG: looking for dangling symlink nodejs-14-minimal/test/check_imagestreams.py (that points to nodejs-14-minimal/test/../common/check_imagestreams.py)
rh_cwt.main.distgit - DEBUG: unlink nodejs-14-minimal/test/check_imagestreams.py
rh_cwt.main.distgit - DEBUG: cp upstreams/nodejs/14-minimal/test/../../test/check_imagestreams.py nodejs-14-minimal/test/check_imagestreams.py
rh_cwt.main.distgit - DEBUG: looking for dangling symlink nodejs-14-minimal/test/check_imagestreams.py (that points to nodejs-14-minimal/test/../common/check_imagestreams.py)
rh_cwt.main.distgit - DEBUG: unlink nodejs-14-minimal/test/check_imagestreams.py
rh_cwt.main.distgit - DEBUG: cp upstreams/nodejs/14-minimal/test/../../test/check_imagestreams.py nodejs-14-minimal/test/check_imagestreams.py
rh_cwt.main.distgit - DEBUG: looking for dangling symlink nodejs-14-minimal/test/check_imagestreams.py (that points to nodejs-14-minimal/test/../common/check_imagestreams.py)
rh_cwt.main.distgit - DEBUG: unlink nodejs-14-minimal/test/check_imagestreams.py
rh_cwt.main.distgit - DEBUG: cp upstreams/nodejs/14-minimal/test/../../test/check_imagestreams.py nodejs-14-minimal/test/check_imagestreams.py
rh_cwt.main.distgit - DEBUG: looking for dangling symlink nodejs-14-minimal/test/check_imagestreams.py (that points to nodejs-14-minimal/test/../common/check_imagestreams.py)
rh_cwt.main.distgit - DEBUG: unlink nodejs-14-minimal/test/check_imagestreams.py
rh_cwt.main.distgit - DEBUG: cp upstreams/nodejs/14-minimal/test/../../test/check_imagestreams.py nodejs-14-minimal/test/check_imagestreams.py
rh_cwt.main.distgit - DEBUG: looking for dangling symlink nodejs-14-minimal/test/check_imagestreams.py (that points to nodejs-14-minimal/test/../common/check_imagestreams.py)
rh_cwt.main.distgit - DEBUG: unlink nodejs-14-minimal/test/check_imagestreams.py
rh_cwt.main.distgit - DEBUG: cp upstreams/nodejs/14-minimal/test/../../test/check_imagestreams.py nodejs-14-minimal/test/check_imagestreams.py
rh_cwt.main.distgit - DEBUG: looking for dangling symlink nodejs-14-minimal/test/check_imagestreams.py (that points to nodejs-14-minimal/test/../common/check_imagestreams.py)
rh_cwt.main.distgit - DEBUG: unlink nodejs-14-minimal/test/check_imagestreams.py
rh_cwt.main.distgit - DEBUG: cp upstreams/nodejs/14-minimal/test/../../test/check_imagestreams.py nodejs-14-minimal/test/check_imagestreams.py
pkubatrh commented 3 years ago

FYI @phracek since you might hit the issue when using Betka