search

sclorg / mysql-container

MySQL container images based on Red Hat Software Collections and intended for OpenShift and general usage. Users can choose between Red Hat Enterprise Linux, Fedora, and CentOS based images.
http://softwarecollections.org
Apache License 2.0
128 stars 201 forks source link

Regression introduce with restarting slave pods with PVs #226

Closed gabemontero closed 6 years ago

gabemontero commented 6 years ago

See https://github.com/sclorg/mysql-container/pull/215/files#r190365336

Should the example/replica template even have a PVC for the slave? If so, how do we refactor the reference PR/commit to allow slave pod restart per the openshift/origin extended tests I referenced?

thanks

hhorak commented 6 years ago

Hm, looking at the change, that was not what I hoped in, I didn't realize how much it is done in case of run-mysqld is run even when the datadir is initialized. We should probably do what was done before (revert this part of the change), just run the daemon and not do anything special. Sorry for the issue, I'll take a look at it and prepare a PR.

gabemontero commented 6 years ago

@adambkaplan @bparees fyi

adambkaplan commented 6 years ago

@hhorak any progress on this item?

bparees commented 6 years ago

thanks @hhorak !