search

sclorg / mysql-container

MySQL container images based on Red Hat Software Collections and intended for OpenShift and general usage. Users can choose between Red Hat Enterprise Linux, Fedora, and CentOS based images.
http://softwarecollections.org
Apache License 2.0
128 stars 201 forks source link

Revert part of "Sync with mysql a bit to make the comparisson simple" #230

Closed hhorak closed 6 years ago

hhorak commented 6 years ago

This reverts part of the commit ff1a1179c1f7914ad4a1c3a60d58f4cf7c07cd0c. This should hopefully fix #226.

hhorak commented 6 years ago

[test-openshift]

hhorak commented 6 years ago

Since it is a revert, I believe no review is needed.

bparees commented 6 years ago

@hhorak what's your process for building/publishing the centos image these days? (when should i expect to see an updated image w/ this change)

hhorak commented 6 years ago

@bparees it should be built after each commit. so it's a matter of minutes usually.

bparees commented 6 years ago

this has actually made things worse, the replicas aren't even coming up anymore: https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/20012/test_pull_request_origin_extended_image_ecosystem/896/

bparees commented 6 years ago

it looks like this test is failing because this check doesn't work anymore within the slave pods:

$ mysqladmin -h localhost -uroot ping
mysqladmin: connect to server at 'localhost' failed
error: 'Your password has expired. To log in you must change it using a client that supports expired passwords.'

which is done by the test as part of prepping the replicas. I need to look into whether that failure is expected.

bparees commented 6 years ago

poking around I think this is an issue of the test case having bit-rotted even more than we realized rather than this PR causing problems. I'll dig further and report back. (I still think this reversion was needed though)

bparees commented 6 years ago

ok i got the test passing again using the currently published mysql image.

Additional changes were required in the TC: https://github.com/openshift/origin/pull/20021