search

sclorg / mysql-container

MySQL container images based on Red Hat Software Collections and intended for OpenShift and general usage. Users can choose between Red Hat Enterprise Linux, Fedora, and CentOS based images.
http://softwarecollections.org
Apache License 2.0
128 stars 201 forks source link

PoC: initialization of datadir #252

Closed kubco2 closed 5 years ago

kubco2 commented 5 years ago

This PR is to point idea. It does not update all entry points of container and all example templates for openshift. Container side: Idea is to add argument "init" into entry points of containers. If this argument is used container exits after datadir initialization.

Openshift side: Init containers are started before the pod app containers are started. They do not have probes so they have enough time to initialize datadir. https://docs.openshift.com/container-platform/3.6/architecture/core_concepts/pods_and_services.html#pods-services-init-containers

centos-ci commented 5 years ago

Can one of the admins verify this patch?

centos-ci commented 5 years ago

Can one of the admins verify this patch?

centos-ci commented 5 years ago

Can one of the admins verify this patch?

hhorak commented 5 years ago

I don't see any specific problem at this point, but it is a big enough change to think it through very well, to make sure it does not have any side effects.

pkubatrh commented 5 years ago

I am not sure I understand the use case for this? From docs it seems like this is a way to wait for some outside services without time-outing the pod that needs said services to function.

Is this supposed to help out with cases where the pod gets restarted before it is ready? Why not just increase the probe timeouts instead?

kubco2 commented 5 years ago

[test]