search

sclorg / mysql-container

MySQL container images based on Red Hat Software Collections and intended for OpenShift and general usage. Users can choose between Red Hat Enterprise Linux, Fedora, and CentOS based images.
http://softwarecollections.org
Apache License 2.0
128 stars 201 forks source link

Use mysqladmin for the liveness probe #289

Closed hhorak closed 4 years ago

hhorak commented 4 years ago

This is the same thing as https://github.com/sclorg/mariadb-container/pull/123.

When using just TCP ping for the port, mysqld daemon expects some data that do not come. With "set global log_error_verbosity=3;", a warning is printed to the errlog, like this: Got an error reading communication packets (every 10s, depending on the liveness probe delay)

This makes issues when tools analyze the errlog, because those innoncent connection errors cannot be distinguised from real connection issues.

With using mysqladmin, similar to the readiness probe, the warning should not be printed any more.

Related: rhbz#1767393 Upstream issue: https://github.com/sclorg/mysql-container/issues/274 Upstream fix: https://github.com/sclorg/mysql-container/pull/285

hhorak commented 4 years ago

This was created by mistake #285 is supposed to be merged, it was closed by accident.

hhorak commented 4 years ago

Since #285 cannot be re-opened, this actually will sever for fixing the issue.

hhorak commented 4 years ago

[test-openshift]

hhorak commented 4 years ago

Review of the same change already done in sclorg/mariadb-container#123. Merging.