sclorg / nginx-container

Nginx high-performance HTTP server and reverse proxy container images based on Red Hat Software Collections and intended for OpenShift and general usage. Users can choose between Red Hat Enterprise Linux, Fedora, and CentOS based images.
http://softwarecollections.org
Apache License 2.0
91 stars 197 forks source link

Support nginx 1.24 #247

Closed phracek closed 1 year ago

phracek commented 1 year ago

This pull request adds support for building, and testing the nginx-container with version 1.24.

phracek commented 1 year ago

The pull request is blocked by #246

phracek commented 1 year ago

Isn't this commit already part of #246?

the commit will be removed as soon as #246 will be merged. I have tested the new 1.24 version and realized that examples/1.24 directory should be part of the pull request that enables testing of new version.

phracek commented 1 year ago

[test]

phracek commented 1 year ago

I have tested Nginx-container 1.24 on Fedora locally and results are:

==============================================
Tests were run for image quay.io/fedora/nginx-124:0
==============================================
Test cases results:

 [PASSED] for 'test-app' test_s2i_usage (00:00:00)
 [PASSED] for 'test-app' test_docker_run_usage (00:00:01)
 [PASSED] for 'test-app' test_application (00:00:03)
 [PASSED] for 'test-app' test_log_output (00:00:02)
 [PASSED] for 'test-app' test_log_volume_output (00:00:02)
 [PASSED] for 'test-app' test_application_user (00:00:02)
 [PASSED] for 'start-hook-test-app' test_pre_init_script (00:00:03)
 [PASSED] for 'miscellaneous-tests' run_dockerfiles_test (00:00:20)

Tests for quay.io/fedora/nginx-124:0 succeeded.

Let's try it in CI

[test]

phracek commented 1 year ago

[test-openshift]

zmiklank commented 1 year ago

Why are you adding new files under 1.22/ directory?

phracek commented 1 year ago

Why are you adding new files under 1.22/ directory?

See https://github.com/sclorg/welcome/blob/master/contribution.md#2-add-sources.

First of all move sources from 1.22 -> 1.24 and then copy them back to 1.22 and fix 1.24 versions in 1.24 directory. Git history is saved.