sclorg / nginx-container

Nginx high-performance HTTP server and reverse proxy container images based on Red Hat Software Collections and intended for OpenShift and general usage. Users can choose between Red Hat Enterprise Linux, Fedora, and CentOS based images.
http://softwarecollections.org
Apache License 2.0
91 stars 198 forks source link

This PR migrates DeploymentConfig to Deployment. #271

Closed phracek closed 11 months ago

phracek commented 1 year ago

This PR migrates DeploymentConfig to Deployment.

See more info here: https://docs.openshift.com/container-platform/4.12/applications/deployments/what-deployments-are.html

Since OPenShift 4.14 DeploymentConfigs are deprecated: https://access.redhat.com/articles/7041372

See example PR here: https://github.com/sclorg/nginx-ex/pull/31 Signed-off-by: Petr "Stone" Hracek phracek@redhat.com

phracek commented 1 year ago

[test-openshift]

phracek commented 12 months ago

[test-openshift]

phracek commented 12 months ago

RHEL8 - OpenShift 4 - 1.22-micro tests failed for this reason:

-----------------------------------------------
Running test test_latest_imagestreams (starting at 2023-11-28 09:23:26-05:00) ... 
-----------------------------------------------
Testing the latest version in imagestreams
Version to check is 1.22-micro.
Checking file imagestreams/nginx-centos.json.
check_version: Compare tags['name']:'latest' against version:'1.22-micro'
check_version: Compare tags['name']:'1.20-ubi9' against version:'1.22-micro'
check_version: Compare tags['name']:'1.20-ubi8' against version:'1.22-micro'
check_version: Compare tags['name']:'1.20-ubi7' against version:'1.22-micro'
The latest version is not present in imagestreams/nginx-centos.json or in latest tag.
Checking file imagestreams/nginx-rhel-aarch64.json.
check_version: Compare tags['name']:'latest' against version:'1.22-micro'
check_version: Compare tags['name']:'1.20-ubi9' against version:'1.22-micro'
check_version: Compare tags['name']:'1.20-ubi8' against version:'1.22-micro'
The latest version is not present in imagestreams/nginx-rhel-aarch64.json or in latest tag.
Checking file imagestreams/nginx-rhel.json.
check_version: Compare tags['name']:'latest' against version:'1.22-micro'
check_version: Compare tags['name']:'1.20-ubi9' against version:'1.22-micro'
check_version: Compare tags['name']:'1.20-ubi8' against version:'1.22-micro'
check_version: Compare tags['name']:'1.20-ubi7' against version:'1.22-micro'
The latest version is not present in imagestreams/nginx-rhel.json or in latest tag.
Test for image 'ubi8/nginx-122-micro:1' FAILED (exit code: 1)
Already on project "default" on server "https://api.core-serv-ocp.hosted.psi.rdu2.redhat.com:6443".
 [PASSED] for 'openshift-remote-cluster' test_nginx_integration (00:01:27)
 [PASSED] for 'openshift-remote-cluster' test_nginx_local_example (00:01:30)
 [PASSED] for 'openshift-remote-cluster' test_nginx_remote_example (00:01:15)
 [PASSED] for 'openshift-remote-cluster' test_nginx_template_from_example_app (00:01:20)
 [PASSED] for 'openshift-remote-cluster' test_nginx_imagestream (00:01:02)
 [FAILED] for 'openshift-remote-cluster' test_latest_imagestreams (00:00:00)
phracek commented 12 months ago

Test results are:

 [PASSED] for 'openshift-remote-cluster' test_nginx_integration (00:01:30)
 [PASSED] for 'openshift-remote-cluster' test_nginx_local_example (00:01:58)
 [PASSED] for 'openshift-remote-cluster' test_nginx_remote_example (00:01:19)
 [PASSED] for 'openshift-remote-cluster' test_nginx_template_from_example_app (00:01:20)
 [PASSED] for 'openshift-remote-cluster' test_nginx_imagestream (00:01:02)
 [PASSED] for 'openshift-remote-cluster' test_latest_imagestreams (00:00:00)
phracek commented 12 months ago

[test-typescript]

phracek commented 12 months ago

nginx-ex pull request has been merged. Let's test it on master branch

[test-openshift]

phracek commented 12 months ago

[test-openshift]

phracek commented 11 months ago

Use master branch in nginx-ex repository

[test-openshift]

phracek commented 11 months ago

[test-upstream]