sclorg / nginx-container

Nginx high-performance HTTP server and reverse proxy container images based on Red Hat Software Collections and intended for OpenShift and general usage. Users can choose between Red Hat Enterprise Linux, Fedora, and CentOS based images.
http://softwarecollections.org
Apache License 2.0
91 stars 198 forks source link

Support Nginx-1.26 on Fedora 40 #297

Closed phracek closed 4 months ago

phracek commented 6 months ago

This pull request adds support Nginx 1.26 on Fedora 40. The rest are not supported for now.

phracek commented 6 months ago

Manually executed tests on Fedora:

 [PASSED] for 'test-app' test_s2i_usage (00:00:01)
 [PASSED] for 'test-app' test_docker_run_usage (00:00:00)
 [PASSED] for 'test-app' test_application (00:00:03)
 [PASSED] for 'test-app' test_log_output (00:00:01)
 [PASSED] for 'test-app' test_log_volume_output (00:00:02)
 [PASSED] for 'test-app' test_application_user (00:00:03)
 [PASSED] for 'start-hook-test-app' test_pre_init_script (00:00:02)
 [FAILED] for 'miscellaneous-tests' run_dockerfiles_test (00:00:01)
phracek commented 6 months ago

Thank you for adding the new version of nginx. Please make sure to not squash the commits when merging.

As soon as the new version is coming, I do not squash commits at all, because each commit is important for git history.

phracek commented 5 months ago

[test-all]

phracek commented 5 months ago

[test-all]

phracek commented 5 months ago

I have re-written this PR, including commit reorganization

[test][test-openshift]

github-actions[bot] commented 5 months ago

Pull Request validation

Failed

🔴 Review - Missing review from a member

Success

🟢 CI - All checks have passed

pkubatrh commented 4 months ago

Please squash https://github.com/sclorg/nginx-container/pull/297/commits/bc5533b92db7483e9648757ea0070e9cf7c17688 and https://github.com/sclorg/nginx-container/pull/297/commits/743fe952ed7a2e9e8c5796108340ed685d91b64e together, otherwise lgtm

phracek commented 4 months ago

Squashed.

phracek commented 4 months ago

[test-all]