search

sclorg / postgresql-container

PostgreSQL container images based on Red Hat Software Collections and intended for OpenShift and general usage. Users can choose between Red Hat Enterprise Linux, Fedora, and CentOS based images.
http://softwarecollections.org
Apache License 2.0
164 stars 216 forks source link

Check for generated files by distgen #428

Closed phracek closed 2 years ago

phracek commented 2 years ago

This commit allows checking files generated by dist-gen.

If files are not generated properly, then the test fails.

pkubatrh commented 2 years ago

Would be much better to add a test for this part of the https://github.com/sclorg/container-common-scripts/blob/master/test.sh script. That way it would only be checked during the test upstream (or locally), it would fail very early (before the rest of the tests is run) and we would not have to add a test case to every single repository (a submodule update would be enough). @phracek WDYT?

phracek commented 2 years ago

@pkubatrh you are right. Just update container-common-scripts and check if files are generated properly before any other tests, makes sense.

phracek commented 2 years ago

@pkubatrh The container-common-scripts repository contains pull request where before calling any test generated files are checked. https://github.com/sclorg/container-common-scripts/pull/218

phracek commented 2 years ago

This pull request is not needed at all. We have PR https://github.com/sclorg/container-common-scripts/pull/275 which does it automatically.