Closed mrbrandao closed 1 year ago
LGTM. I will extend the documentation with my notes when this PR is merged. @mrbrandao Do you have some minimal OpenShift configuration for your example that you could include?
LGTM. I will extend the documentation with my notes when this PR is merged. @mrbrandao Do you have some minimal OpenShift configuration for your example that you could include?
Thanks @Lupphes , at the moment I'm not using any special config, everything as default running with restricted scc.
@mrbrandao thank you for your contribution. I will merge it as the tests passed.
[test-all]
[test-all]
@fila43 @Lupphes, I see the TESTS="run_s2i_enable_ssl_test"
is failing. I can fix with:
-# chmod og-rwx server.key
+chmod og-rwx certs/*.key
however this will fail in openshift :
=> sourcing /opt/app-root/src/postgresql-pre-start/enable_ssl.sh ...
chmod: changing permissions of 'server.key': Operation not permitted
do you have any suggestion? Perhaps we can leave the pre-start script but try to skip it when using a oc new-app
.
Let me know your thougths.
Thank you
I've updated with a fix to the run_s2i_enable_ssl_test
also improved the README, by adding examples on how to use with restriced
and anyuid
scc.
With that we can leave the chmod
in the pre-start script and pass the tests. Also added instructions on how to overwrite the pre-start scripts, so we can ran this as restricted scc in OpenShift.
Let me know if anything. Thanks again
[test-all]
[test-all]
There are weird test-case (Openshift 4) fails. Unfortunately, I am not an expert in this area. @phracek PTAL.
[test-all]
[test-all]
The majority of tests passed. Openshift 4 test failed due to connection issues: Error: Failed to download metadata for repo 'rhel-9-server-baseos-rpms': Cannot download repomd.xml: Cannot download repodata/repomd.xml: All mirrors were tried
RHEL8 tests failed due to a broken test run_master_restart_test
So I see it as LGTM and ready to merge.
Those changes improves and provide examples on how to use the
examples/enable-ssl
in OpenShiftenable-ssl/server*
toenable-ssl/certs/tls*
This allows user to mount their keys in a single directory without having to mount secrets on top configurations file in
/opt/app-root/src
e.g:chmod
command from the pre-start scriptCerts are better to be mounted in OpenShift with the proper permissions already set from the
pod.spec.volumes.secret.defaultMode
When using the deployment in OpenShift without anyuid scc the following error was ocurring with:
server.key
andserver.crt
to the newcerts
directory