sclorg / postgresql-container

PostgreSQL container images based on Red Hat Software Collections and intended for OpenShift and general usage. Users can choose between Red Hat Enterprise Linux, Fedora, and CentOS based images.
http://softwarecollections.org
Apache License 2.0
164 stars 216 forks source link

Remove `run_master_restart_test` tests #509

Closed phracek closed 1 year ago

phracek commented 1 year ago

Container platform

Podman/Docker

Version

No response

OS version of the container image

RHEL 8, RHEL 9, CentOS Stream 9

Bugzilla, Jira

No response

Description

It looks like the tests `` is failing on several platforms. I would remove it.

See logs here: https://github.com/sclorg/postgresql-container/pull/507

 [PASSED] for 'postgresql-container_tests' run_replication_test (00:00:06)
 [FAILED] for 'postgresql-container_tests' run_master_restart_test (00:01:13)
 [PASSED] for 'postgresql-container_tests' run_doc_test (00:00:01)

Reproducer

No response

zmiklank commented 1 year ago

I think that more elaborate explanation on why to remove this test is needed. If we would remove all tests just because they are failing then we do not really need any tests at all.

Could you please explain why specifically this test should be removed instead of being fixed?

fila43 commented 1 year ago

From my point of view. It tests unsupported functionality. And it would cost a lot of afford to investigate it. I've spent some time debugging it but without any success. It fails randomly. I have some thoughts on catching it, but I am unsure whether it is worth it.

zmiklank commented 1 year ago

From my point of view. It tests unsupported functionality. And it would cost a lot of afford to investigate it. I've spent some time debugging it but without any success. It fails randomly. I have some thoughts on catching it, but I am unsure whether it is worth it.

Hi, thank for your reply. Is there somewhere a list of supported functionality? So we could enclose it in the commit message in proceeding PR?

fila43 commented 1 year ago

Here, we have information about replication. It's just a proof-of-concept functionality. That's why I interpret it as unsupported.

phracek commented 1 year ago

This issues is resolved by https://github.com/sclorg/postgresql-container/pull/510. Closing.