search

sclorg / postgresql-container

PostgreSQL container images based on Red Hat Software Collections and intended for OpenShift and general usage. Users can choose between Red Hat Enterprise Linux, Fedora, and CentOS based images.
http://softwarecollections.org
Apache License 2.0
164 stars 216 forks source link

Do not ignore SQL failures and check that we still work with previous data when changing password #544

Closed hhorak closed 10 months ago

hhorak commented 10 months ago

Fix also postgresql_cmd function that should not ignore SQL errors (thus using ON_ERROR_STOP option now) and was often called with an interactive input using <<< but podman run is run in non-interactive mode, resulting in the SQL commands to not be printed, so checking them later did not work and errors are not visible. Using -c option solves this.

Function test_postgresql was called with a parameter that was not used anywhere. This function used CREATE EXTENSION to test proper PostgreSQL functionality, that only admin have permissions for. So, the parameter of test_postgresql function was changed to have a useful meaning. The meaning is that only if the parameter is "admin", the CREATE EXTENSION statement is run to not see "Not enough permissions" error when the contianer is run as a normal user.

hhorak commented 10 months ago

[test]

hhorak commented 10 months ago

[test]

hhorak commented 10 months ago

LGTM. I would consider adding '-At -c' params into postgresql_cmd function directly (even though I noticed, that some commands do not use the '-At' params currently), but I am also OK with this solution.

I'd rather leave it flexible, so the caller of postgresql_cmd can decide what format and way of input to use.