search

sclorg / postgresql-container

PostgreSQL container images based on Red Hat Software Collections and intended for OpenShift and general usage. Users can choose between Red Hat Enterprise Linux, Fedora, and CentOS based images.
http://softwarecollections.org
Apache License 2.0
164 stars 215 forks source link

Testing requires additional software #564

Open eifrach opened 6 months ago

eifrach commented 6 months ago

should highlight the need of go-md2man

go install github.com/cpuguy83/go-md2man@latest

https://github.com/sclorg/postgresql-container/blob/d0cecca7766a6150489228dc2670143bf73a3997/README.md?plain=1#L124-L126

phracek commented 6 months ago

@eifrach Please file a PR. Thanks.

zmiklank commented 6 months ago

Hi @eifrach, I see there is some section about go-md2man in the readme already [1]. However, it seems to be outdated, as it does not seem that a rpm for this program exists in fedora's repositories.

I did try to install go-md2man via go install as you suggested but the test scripts were still failing on bash: line 1: go-md2man: command not found. If you have some reproducible way how to install the go-md2man that is not mentioned in the readme, please feel free to file a PR for it, as phracek mentioned above. Otherwise I'll say we can just remove the part about installing go-md2man via dnf.

[1] https://github.com/sclorg/postgresql-container?tab=readme-ov-file#contributing-guidelines

eifrach commented 5 months ago

check if the $GOBIN in your path.

 → which go-md2man
/home/eifrach/go/bin/go-md2man