search

sclorg / rpm-list-builder

RPM List Builder helps you to build a list of defined RPM packages including Software Collection from the recipe file
GNU General Public License v2.0
4 stars 8 forks source link

Fix naming of packages added to target koji tag #105

Closed khardix closed 6 years ago

khardix commented 6 years ago

KojiBuilder was incorrectly handling naming of metapackages when adding them to target tag, essentialy duplicated the collection name (i.e. adding rh-ror50-rh-ror50 in place of just rh-ror50).

This fix adds a check for the metapackage name, avoiding the duplication.

khardix commented 6 years ago

Next attempt at this fix. This time, I left it in two commits:

  1. The first one (c8ff0ca9bfd253d5ef5fba6b0d187bc62ba5e1bb) contains the fix itself, extracted into separate function (as requested), with test and associated changes in related functions.
  2. The other one is refactoring (making regular methods from static ones, extracting repeated test setup into fixture, etc.).