search

sclorg / rpm-list-builder

RPM List Builder helps you to build a list of defined RPM packages including Software Collection from the recipe file
GNU General Public License v2.0
4 stars 8 forks source link

Retrieve sources from lookaside cache with {fed,rh}pkg #113

Closed khardix closed 5 years ago

khardix commented 5 years ago

When using the {fed,rh}pkg downloader, also retrieve the sources from the lookaside cache.

The koji builder cannot build an SRPM in the working directory if it does not have all the package sources and patches available, since it does not rely on any *pkg command, but uses rpm/rpmbuild directly. The other relevant builders (except the custom one, which leaves that up to the user) all use *pkg srpm for building the SRPM, which calls *pkg sources if necessary.

The koji builder could of course be adapted to using the *pkg command internally, but I believe this to be an unnecessary coupling/dependency. With this patch, both ways will be working.

Thoughts?

hroncok commented 5 years ago

(Assuming the test will pass which they don't.)

junaruga commented 5 years ago

Thanks for merging!