sclorg / rpm-list-builder

RPM List Builder helps you to build a list of defined RPM packages including Software Collection from the recipe file
GNU General Public License v2.0
4 stars 8 forks source link

Set correct path for flake8. #36

Closed junaruga closed 7 years ago

junaruga commented 7 years ago

@hroncok @khardix

flake8 check did not work correctly for rpmlb directory. flake8 did not complain for not existing directory lib/rpmlb/.

Actually current source has below result for flake8.

$ flake8 rpmlb/ tests/ setup.py
rpmlb/cli.py:37:80: E501 line too long (84 > 79 characters)
rpmlb/cli.py:78:80: E501 line too long (95 > 79 characters)

I added "--show-source --statistics" because those look more useful options.

$ flake8 --show-source --statistics rpmlb/ tests/ setup.py
rpmlb/cli.py:37:80: E501 line too long (84 > 79 characters)
    type=click.Path(exists=True, file_okay=False, writable=True, resolve_path=True),
                                                                               ^
rpmlb/cli.py:78:80: E501 line too long (95 > 79 characters)
    """Download and build RPMs listed in RECIPE_FILE under RECIPE_NAME (such as 'python33')."""
                                                                               ^
2     E501 line too long (84 > 79 characters)
hroncok commented 7 years ago

Personally, I would split the commit into two (i.e. "Set correct path for flake 8" and "Fix style issues" or similar), to have one conceptual change in one commit.

That would be better, yes. Still, better as is than nothing.

junaruga commented 7 years ago

OK, I will split those to 2 commits. I am fine. In my experience in contributing open source project, move than 100 times PR for contribution latest 1 year, I have experienced to be asked to split commits by other people only at once, as far as I know. I guess that your sense is not majority. But I am fine.

junaruga commented 7 years ago

Merged with 2 commits.