Closed junaruga closed 7 years ago
Personally, I would split the commit into two (i.e. "Set correct path for flake 8" and "Fix style issues" or similar), to have one conceptual change in one commit.
That would be better, yes. Still, better as is than nothing.
OK, I will split those to 2 commits. I am fine. In my experience in contributing open source project, move than 100 times PR for contribution latest 1 year, I have experienced to be asked to split commits by other people only at once, as far as I know. I guess that your sense is not majority. But I am fine.
Merged with 2 commits.
@hroncok @khardix
flake8 check did not work correctly for
rpmlb
directory. flake8 did not complain for not existing directorylib/rpmlb/
.Actually current source has below result for flake8.
I added "--show-source --statistics" because those look more useful options.