search

sclorg / rpm-list-builder

RPM List Builder helps you to build a list of defined RPM packages including Software Collection from the recipe file
GNU General Public License v2.0
4 stars 8 forks source link

Extend initialization interface of a builder #73

Closed khardix closed 7 years ago

khardix commented 7 years ago

As discussed in sclorg#58 (relevant discussion), there is a need for a custom builder initialization not skipped on --resume. This PR extends the interface of BaseBuilder.__init__ and relevant methods to allow for such initialization.

khardix commented 7 years ago

@junaruga, could you please go over the added docstrings for BaseBuilder.{__init__,before,after} and confirm that they correspond to what you have in mind for them?

After making sure that I understood them correctly, I will go over existing builders and refactor them to use the new __init__ interface.

khardix commented 7 years ago

There was a syntax error on Py3.4 that was OK on later Pythons, oops 😄. Should be fixed now.

khardix commented 7 years ago

Rebased on current master branch.

khardix commented 7 years ago

Should be all set now. @junaruga, ready for review.

junaruga commented 7 years ago

It looks good to me!