search

sclorg / rpm-list-builder

RPM List Builder helps you to build a list of defined RPM packages including Software Collection from the recipe file
GNU General Public License v2.0
4 stars 8 forks source link

Revert monkeypatches in test_custom #86

Closed ncoghlan closed 7 years ago

ncoghlan commented 7 years ago

Uses the pytest monkeypatch fixture to ensure that changes to the Custom class are reverted after the relevant tests.

hroncok commented 7 years ago

I think you've uncovered an issue, that the monkeypatching influenced other test and those test were not supposed to pass as they were.

https://github.com/ncoghlan/rpm-list-builder/blob/2dd627b6542d60dcaf1e838a4e1ec92e28cb2e98/rpmlb/yaml.py#L20 - this should also accept Path objects on older Pythons.

ncoghlan commented 7 years ago

@hroncok Ah, that would be why I didn't see the failure locally - I hadn't done a full tox run since fixing this. Update pushed with the extra str() call.

hroncok commented 7 years ago

Thanks. Now the Travis build pass. If you squash the first two commits, I'll merge.

ncoghlan commented 7 years ago

@hroncok Rebased & squashed.