search

sclorg / rpm-list-builder

RPM List Builder helps you to build a list of defined RPM packages including Software Collection from the recipe file
GNU General Public License v2.0
4 stars 8 forks source link

Consistently close click contexts in test_cli #87

Closed ncoghlan closed 7 years ago

ncoghlan commented 7 years ago
ncoghlan commented 7 years ago

When I was attempting to use CliRunner.invoke in #79, I kept getting strange interactions with test_cli when I tried to run both of them in the same process.

While I never figured that out, and ended up switching to using a full subprocess for the #79 tests, this PR is a result of explore a theory that click may not like having multiple contexts created from a command without consistently closing them afterwards.

Given that it didn't actually seem to help resolve any of the side effects, I don't mind if this doesn't get merged, but also figured it made sense to offer it and let you make the decision on whether or not it is an improvement.

junaruga commented 7 years ago

I merged it. Thank you!