sclorg / rpm-list-builder

RPM List Builder helps you to build a list of defined RPM packages including Software Collection from the recipe file
GNU General Public License v2.0
4 stars 8 forks source link

Remove hardcoded "rhpkg". #88

Closed junaruga closed 7 years ago

junaruga commented 7 years ago

This fixes https://github.com/sclorg/rpm-list-builder/issues/66 and https://github.com/sclorg/rpm-list-builder/issues/83 .

Specification is here https://github.com/sclorg/rpm-list-builder/issues/83#issue-245364831 .

junaruga commented 7 years ago

I tested below cases too as acceptance test just in case.

$ rpmlb \
  --download fedpkg \
  --build mock \
  --mock-config fedora-rawhide-x86_64 \
  --branch master \
  --verbose \
  tests/fixtures/recipes/joke.yml \
  joke 2>&1 | tee rpmlb.log
$ rpmlb \
  --download fedpkg \
  --build mock \
  --pkg-cmd fedpkg \
  --mock-config fedora-rawhide-x86_64 \
  --branch master \
  --verbose \
  tests/fixtures/recipes/joke.yml \
  joke 2>&1 | tee rpmlb.log
$ rpmlb \
  --download rhpkg \
  --build mock \
  --pkg-cmd rhpkg \
  --mock-config rhscl-2.4-rh-ror50-rhel-7-x86-64 \
  --branch rhscl-2.4-rh-ror50-rhel-7 \
  --verbose \
  tests/fixtures/recipes/ror.yml \
  rh-ror50 2>&1 | tee rpmlb.log
$ rpmlb \
  --download fedpkg \
  --build copr \
  --copr-repo rh-ror50-test \
  --branch master \
  --verbose \
  tests/fixtures/recipes/joke.yml \
  joke 2>&1 | tee rpmlb.log
$ rpmlb \
  --download rhpkg \
  --build mock \
  --mock-config rhscl-2.4-rh-ror50-rhel-7-x86-64 \
  --branch rhscl-2.4-rh-ror50-rhel-7 \
  --verbose \
  tests/fixtures/recipes/ror.yml \
  rh-ror50 2>&1 | tee rpmlb.log
junaruga commented 7 years ago

@khardix thanks for the review. I fixed those, and rebased on latest master branch.

junaruga commented 7 years ago

Merged with squash. The document is later.