Closed phracek closed 2 years ago
What container is it trying to run in so that I can try with IMAGE_NAME= ?
Is the base s2i image - f32/nodejs:12 ? and if so which registry is it in?
I looked here but I can't find anything that looks like a nodejs container - https://registry.fedoraproject.org/
I guess I don't understand the flow and how I can recreate for fedora? For RHEL and ubi I can just point to the published containers with IMAGE_NAME and then run/debug the tests. @phracek, @hhorak
You can clone this repository and build your own container image via make tag TARGET=fedora VERSIONS=12
. What I'm confused about is that the error message here is different from what I¨ve seen in PRs.
@frenzymadness thanks build container like that and then ran with:
export IMAGE_NAME=f32/nodejs ./run
[PASSED] for 'app' test_run_app_application [PASSED] for 'app' test_s2i_usage [PASSED] for 'app' test_scl_usage [PASSED] for 'app' test_connection [PASSED] for 'app' test_docker_run_usage [PASSED] for 'app' test_scl_variables_in_dockerfile [PASSED] for 'app' test_npm_functionality [PASSED] for 'app' test_check_build_using_dockerfile [PASSED] for 'app' test_nodemon_removed [PASSED] for 'app' test_npm_cache_cleared [PASSED] for 'app' test_npm_tmp_cleared [PASSED] for 'app' kill_test_application [PASSED] for 'app' test_dev_mode_true_development [PASSED] for 'app' test_dev_mode_false_production [PASSED] for 'node_env_development' test_run_app_application [PASSED] for 'node_env_development' test_connection [PASSED] for 'node_env_development' test_nodemon_present [PASSED] for 'node_env_development' test_npm_cache_exists [PASSED] for 'node_env_development' kill_test_application [PASSED] for 'node_env_development' test_dev_mode_true_development [PASSED] for 'node_env_development' test_dev_mode_false_development [PASSED] for 'dev_mode' test_run_app_application [PASSED] for 'dev_mode' test_connection [PASSED] for 'dev_mode' test_nodemon_present [PASSED] for 'dev_mode' test_npm_cache_exists [PASSED] for 'dev_mode' kill_test_application [PASSED] for 'dev_mode' test_dev_mode_true_development [PASSED] for 'dev_mode' test_dev_mode_false_production [PASSED] for 'hw' test_safe_logging [PASSED] for 'hw' test_run_hw_application [PASSED] for 'hw' test_incremental_build [PASSED] for 'hw' test_build_express_webapp [PASSED] for 'clients' express [FAILED] for 'clients' pino [PASSED] for 'clients' prom-client [PASSED] for 'binary' test_run_binary_application
So I do see the failure in fedora as well.
The failures seem to be occuring in the pino CI runs as well - https://github.com/pinojs/pino/runs/4371438895?check_suite_focus=true
I tried going back to previous pino versions and the tests still failed so I don't think it is related to the pino version/branch, maybe instead of the types module published externally.
I suggest we watch the pino issues to see if it is flagged/resolved there. I reached out to one of the maintainers I know to see if it is a known issue.
@mhdawson What about disabling this test in our container?
The test in question fixed.
Issue is fixed. Closing it.
The tests suite 'pino' clients failed:
See the final result summary: