search

sclorg / s2i-nodejs-container

NodeJS images based on Red Hat Software Collections and intended for OpenShift and general usage, that provide a platform for building and running NodeJS applications. Users can choose between Red Hat Enterprise Linux, Fedora, and CentOS based images.
http://softwarecollections.org
Apache License 2.0
164 stars 286 forks source link

clients: Pino tests are failing #381

Open lholmquist opened 1 year ago

lholmquist commented 1 year ago

the pino tests are having failures on these platforms in the testing farm:

Fedora Node 18 Fedora Node 16 RHEL9 - Unsubscribed host - node 16

cc @lholmquist @mhdawson

pkubatrh commented 1 year ago

Discussed the failure of pino test case on the nodejs meeting for a bit, we have decided to try and pin a specific version of the module and test with that. If we figure out the tests are still as flaky as they were before this change, let's focus on making the upstream pino test suite more hardened to failures.

phracek commented 1 year ago

What about having two tests? The first one will be freezed 'pino', 'faas' that should pass always. The other test will use the latest upstream versions, it will be marked as unstable in case of failure. See PR here: https://github.com/sclorg/s2i-nodejs-container/pull/342

mhdawson commented 1 year ago

@phracek that sounds reasonable. One question I had is if the pino tests are flaky or have just never passed on RHEL 9?