search

sclorg / s2i-perl-container

Perl container images based on Red Hat Software Collections and intended for OpenShift and general usage, that provide a platform for building and running Perl applications. Users can choose between Red Hat Enterprise Linux, Fedora, and CentOS based images.
http://softwarecollections.org
Apache License 2.0
16 stars 56 forks source link

Rewrite all /opt/app-root to $APP_ROOT variable #241

Open michal-josef-spacek opened 2 years ago

michal-josef-spacek commented 2 years ago

s2i image has $APP_ROOT environment variable, but in code there are many hardcoded variables

phracek commented 2 years ago

This is already fixed by #236

michal-josef-spacek commented 2 years ago

@phracek I don't think that is ok or that's working.

e.g. https://github.com/sclorg/s2i-perl-container/blob/master/5.32/s2i/bin/assemble#L15 https://github.com/sclorg/s2i-perl-container/blob/master/5.32/s2i/bin/assemble#L101 Multiple hardcoded in https://github.com/sclorg/s2i-perl-container/blob/master/5.32/s2i/bin/run Same https://github.com/sclorg/s2i-perl-container/blob/master/5.32/Dockerfile.fedora#L11

And most funny part: https://github.com/sclorg/s2i-perl-container/blob/master/5.32/Dockerfile.fedora#L47

# Copy extra files to the image.
COPY ./root/ /

Which copies ./root/opt/app-root directly to /

zmiklank commented 1 year ago

I will take a look at this.

zmiklank commented 1 year ago

Seems there already is some initiative about this: https://github.com/sclorg/s2i-perl-container/pull/288

michal-josef-spacek commented 1 year ago

We need to test and rewrite other Perl versions.

phracek commented 7 months ago

@michal-josef-spacek It looks like this issue is already fixed by #288. Can we close it?

michal-josef-spacek commented 7 months ago

@phracek There are places, which need to rewrite still

zmiklank commented 7 months ago

@phracek @michal-josef-spacek I volunteered to do this, but I put so low priority on it that it is still not finished. I may reprioritize it a bit.