search

sclorg / s2i-perl-container

Perl container images based on Red Hat Software Collections and intended for OpenShift and general usage, that provide a platform for building and running Perl applications. Users can choose between Red Hat Enterprise Linux, Fedora, and CentOS based images.
http://softwarecollections.org
Apache License 2.0
16 stars 56 forks source link

Add Dockerfile.rhel8 for version 5.32 #308

Closed phracek closed 4 months ago

phracek commented 4 months ago

Add Dockerfile.rhel8 for version 5.32 Support start since May 2022.

This pull request adds support for building and testing version 5.32 in RHEL8

Closes: #306

phracek commented 4 months ago

[test]

phracek commented 4 months ago

@jplesnik @michal-josef-spacek Please take a look at it? Thanks. Support is since May 2022 till Apr 2025.

We forgot it totally.

phracek commented 4 months ago

For faster review, diff between 5.32/Dockerfile.rhel8 and 5.32/Dockerfile.rhel9:

diff Dockerfile.rhel8 Dockerfile.rhel9
1c1
< FROM ubi8/s2i-base:1
---
> FROM ubi9/s2i-base:1
29c29
<       name="ubi8/${NAME}-${PERL_SHORT_VER}" \
---
>       name="ubi9/${NAME}-${PERL_SHORT_VER}" \
35c35
<       usage="s2i build <SOURCE-REPOSITORY> ubi8/${NAME}-${PERL_SHORT_VER}:latest <APP-NAME>"
---
>       usage="s2i build <SOURCE-REPOSITORY> ubi9/${NAME}-${PERL_SHORT_VER}:latest <APP-NAME>"
38,39d37
< RUN yum -y module reset perl
<
41d38
<     yum -y module enable perl:$PERL_VERSION && \
michal-josef-spacek commented 4 months ago

lgtm too. I tested it and it seems ok.