sclorg / s2i-php-container

PHP container images based on Red Hat Software Collections and intended for OpenShift and general usage, that provide a platform for building and running PHP applications. Users can choose between Red Hat Enterprise Linux, Fedora, and CentOS based images.
http://softwarecollections.org
Apache License 2.0
107 stars 331 forks source link

add support for composer global plugins #210

Open rafaeltuelho opened 6 years ago

rafaeltuelho commented 6 years ago

Some applications rely on composer plugins to properly install their dependencies. For example, some applications delegates to composer the installations of npm and bower packages. Composer uses the plugin fxpio/composer-asset-plugin for this kind of 3rd party deps management. The issue is fxpio/composer-asset-plugin only can be installed/enable globally. So the image should install install using the command:

composer global require "fxp/composer-asset-plugin:~1.3"
rafaeltuelho commented 6 years ago

I managed to workaround this "limitation" by copying the original s2i assemble script and embedding it inside my app src (.s2i/bin/assemble). See the customized version here: https://gist.github.com/rafaeltuelho/628da4576ec9f34c6c28cd9e5b909ef0#file-customized_php_s2i_assemble-sh-L46-L51

omron93 commented 6 years ago

@remicollet Could you please tak a look if it makes sense to use fxpio/composer-asset-plugin by default in our assemble script? Also what do you think about https://github.com/sclorg/s2i-php-container/pull/166 which relates also to composer?

phracek commented 1 year ago

@remicollet Hi remi, what do you think about this issue? Does it make sense? Thank you. Petr

remicollet commented 1 year ago

@remicollet Hi remi, what do you think about this issue? Does it make sense? Thank you. Petr

I don't think it make sense, we obviously cannot install everything and this project seems inactive (last release in 2019, 4 years ago)