sclorg / s2i-php-container

PHP container images based on Red Hat Software Collections and intended for OpenShift and general usage, that provide a platform for building and running PHP applications. Users can choose between Red Hat Enterprise Linux, Fedora, and CentOS based images.
http://softwarecollections.org
Apache License 2.0
107 stars 331 forks source link

Support PHP 8.2 version for Fedora container #421

Closed phracek closed 1 year ago

phracek commented 1 year ago

This pull request adds support for PHP version 8.2.

phracek commented 1 year ago

First test

[test]

phracek commented 1 year ago

@remicollet @hhorak @pkubatrh Can you please review it? Only Fedora PHP-8.2 version is tested. Everything else has .exclude files. Thanks

remicollet commented 1 year ago

LGTM Perhaps missing php.ini changes (but only about new max_multipart_body_parts)

@@ -425,6 +425,11 @@
 ; How many GET/POST/COOKIE input variables may be accepted
 ;max_input_vars = 1000

+; How many multipart body parts (combined input variable and file uploads) may
+; be accepted.
+; Default Value: -1 (Sum of max_input_vars and max_file_uploads)
+;max_multipart_body_parts = 1500
+
 ; Maximum amount of memory a script may consume
 ; https://php.net/memory-limit
 memory_limit = 128M
phracek commented 1 year ago

[test-all]

joejoseph00 commented 5 months ago

From a performance perspective, PHP 8.3 completely blows away 8.2 and all predecessors https://github.com/sclorg/s2i-php-container/issues/435

joejoseph00 commented 5 months ago

For that reason, we're looking to skip 8.2 ASAP and move directly to 8.3