search

sclorg / s2i-php-container

PHP container images based on Red Hat Software Collections and intended for OpenShift and general usage, that provide a platform for building and running PHP applications. Users can choose between Red Hat Enterprise Linux, Fedora, and CentOS based images.
http://softwarecollections.org
Apache License 2.0
107 stars 331 forks source link

Imagestream generator #441

Closed zmiklank closed 5 months ago

zmiklank commented 5 months ago

This PR removes tag "7.3" as it not standard for other sclorg images. I also removes tring "supports":"php:8.0,php" from the tag. Could that cause a problem?

zmiklank commented 5 months ago

[test-openshift]

zmiklank commented 5 months ago

@phracek seems like problem with ansible scripts?

phracek commented 5 months ago

@phracek seems like problem with ansible scripts?

No problem with subscription: "The system is unable to complete the requested transaction (HTTP error code 500: Internal Server Error)"

phracek commented 5 months ago

[test-openshift]

zmiklank commented 5 months ago

We need an answer for the first question before merging this:

This PR removes tag "7.3" as it not standard for other sclorg images. I also removes tring "supports":"php:8.0,php" from the tag. Could that cause a problem?

zmiklank commented 5 months ago

We need an answer for the first question before merging this:

This PR removes tag "7.3" as it not standard for other sclorg images. I also removes tring "supports":"php:8.0,php" from the tag. Could that cause a problem?

@pkubatrh WDYT?

phracek commented 5 months ago

PHP-7.3 is still supported for RHEL7 images. I don't follow what you mean by removing tag '7.3'?

zmiklank commented 5 months ago

PHP-7.3 is still supported for RHEL7 images. I don't follow what you mean by removing tag '7.3'?

There is "7.3-ubi7" and a "7.3" tag. Those are two different tags we provide, the "7.3" being non-standard - not all container images' imagrestreams provide it. Currently the imagestream generator can not generate tags in format of app version only (7.3).

pkubatrh commented 5 months ago

LGTM. The change might cause some minor breakege, but since we are standardizing on a specific name format I say this is worth the risk.