sclorg / s2i-python-container

Python container images based on Red Hat Software Collections and intended for OpenShift and general usage, that provide a platform for building and running Python applications. Users can choose between Red Hat Enterprise Linux, Fedora, and CentOS based images.
http://softwarecollections.org
Apache License 2.0
261 stars 325 forks source link

build Fedora and CentOS Stream images also for arm64 #660

Closed zmiklank closed 6 months ago

zmiklank commented 6 months ago

Depends on: https://github.com/sclorg/s2i-base-container/pull/292 Resolves: https://github.com/sclorg/s2i-python-container/issues/659

zmiklank commented 6 months ago

LGTM. But question. Why to not enable all archs like in postgresql-container

Sure, we can do that. I was going with minimal option, but I am OK also with enabling all the arch. If not for python, then at least for s2i base and core. Should I update the PR accordingly?

pkubatrh commented 6 months ago

+1 to enabling all for s2i-core and s2i-base (since we already build all for postgresql anyway), I would keep only arm for python, as we didnt get any requests for other architectures yet.

zmiklank commented 6 months ago

Done for s2i-base and s2i-core: https://github.com/sclorg/s2i-base-container/pull/292/