sclorg / s2i-ruby-container

Ruby container images based on Red Hat Software Collections and intended for OpenShift and general usage, that provide a platform for building and running Ruby applications. Users can choose between Red Hat Enterprise Linux, Fedora, and CentOS based images.
http://softwarecollections.org
Apache License 2.0
55 stars 156 forks source link

Add Ruby 3.2 #499

Closed pvalena closed 1 year ago

pvalena commented 1 year ago

In Fedora container:

bash-5.2$ ruby -v
ruby 3.2.2 (2023-03-30 revision e51014f9c0) [x86_64-linux]

Build log: https://gist.github.com/pvalena/4caf0873c714acc8e2b14dc6d88de315

phracek commented 1 year ago

We have agreed on the internal meeting, that ruby-3.2 container will not be part of sclorg/s2i-ruby-container. We will skip it and later on add ruby-3.3.

@jackorp Am I right?

jackorp commented 1 year ago

Yep, no Ruby 3.2 for sclorg/s2i-ruby-container.

For Fedora IIRC the comment was that if the community really wants it, we can merge, build and it's on a self-support basis. As in, you find a bug, you fix it yourself.

pvalena commented 1 year ago

This is just for testing purposes... can I push it to 3.2-experimental branch or similar?

zmiklank commented 1 year ago

Related issue: https://github.com/sclorg/s2i-ruby-container/issues/461.

zmiklank commented 1 year ago

This is just for testing purposes... can I push it to 3.2-experimental branch or similar?

Will it bring you any benefits to move this from your fork to non-main sclorg branch?

pvalena commented 1 year ago

This is just for testing purposes... can I push it to 3.2-experimental branch or similar?

Will it bring you any benefits to move this from your fork to non-main sclorg branch?

Just for transparency. In case someone wants to experiment with it as well.

pvalena commented 1 year ago

We have agreed on the internal meeting, that ruby-3.2 container will not be part of sclorg/s2i-ruby-container. We will skip it and later on add ruby-3.3.

@jackorp Am I right?

I just want to check that everything still works with Ruby 3.2 even if it's not packaged. E.g. using Ruby from my COPR: https://copr.fedorainfracloud.org/coprs/pvalena/ruby/

pvalena commented 1 year ago

Btw. there's like 20 other random branches, so it probably doesn't matter...

zmiklank commented 1 year ago

Btw. there's like 20 other random branches, so it probably doesn't matter...

That is true, but they are kind of polluting the repository and it would be difficult to get rid of them and make sure not to delete someone's work-in-progress. I would therefore suggest primarily using forks in the future. However, your point seem like a valid one to me.

pvalena commented 1 year ago

Done: https://github.com/sclorg/s2i-ruby-container/tree/3.2-experimental

pvalena commented 1 year ago

Thanks for the comments!

pvalena commented 1 year ago

And here's the built image, in case someone's interested: quay.io/s2i-ruby/fedora:3.2-experimental