search

sclorg / s2i-ruby-container

Ruby container images based on Red Hat Software Collections and intended for OpenShift and general usage, that provide a platform for building and running Ruby applications. Users can choose between Red Hat Enterprise Linux, Fedora, and CentOS based images.
http://softwarecollections.org
Apache License 2.0
55 stars 156 forks source link

Test with rails-ex on branch 3.3 going forward. #518

Closed jackorp closed 9 months ago

jackorp commented 9 months ago

rails-ex for Ruby 3.3 needs updated dependencies but that's not possible as RHEL 7 requires pg <= 1.2.3 due to the old PostgreSQL available. Therefore, by default we'll use rails-ex@3.3 for tests, older rubies such as 3.1 or 2.5 will keep using the rails-ex@master.

jackorp commented 9 months ago

PTAL @phracek I hope I remembered correctly from our meetings that the new rails-ex branch will be the new de-facto default.

Not sure, do some openshift tests somewhere also need similar adjusting?

jackorp commented 9 months ago

@pvalena PTAL for bash. I used a function to cut down on repetition in the Openshift tests. I think we want to differentiate the remote ref in all openshift tests due to the Rails app dependency changes.

And I think it'd be a good idea to run tests with this to validate I didn't make behavior changes for the current state before inclusion of Ruby 3.3 @phracek

phracek commented 9 months ago

[test-all]