sclorg / s2i-ruby-container

Ruby container images based on Red Hat Software Collections and intended for OpenShift and general usage, that provide a platform for building and running Ruby applications. Users can choose between Red Hat Enterprise Linux, Fedora, and CentOS based images.
http://softwarecollections.org
Apache License 2.0
55 stars 156 forks source link

Fix ruby OpenShift 4 tests suite and and 3.3 imagestreams #540

Closed phracek closed 6 months ago

phracek commented 6 months ago

This pull request fixes OpenShift 4 tests for version 3.3. In case ruby 3.3 is tested, then use rails-ex#3.3 branch as well.

In this pull request are updated also 3.3 imagestreams

phracek commented 6 months ago

[test-openshift]

phracek commented 6 months ago

@zmiklank @jackorp Review please

phracek commented 6 months ago

https://github.com/sclorg/s2i-ruby-container/issues/530

phracek commented 6 months ago

[test-all]

phracek commented 6 months ago

Settings variable to 'VERSION=' or 'VERSION=""' cause a problems in our testing suite. See here: https://github.com/sclorg/container-common-scripts/blob/master/tag.sh#L35

it raises an exception like:

Tagged versions are: 3.3
-> Tagging image 'b69c9f006c16b7afebf3f6a50559143f962ae3c62cffcd90389e73f4169e6b02' as 'quay.io/fedora/ruby-33:' and 'quay.io/fedora/ruby-33:latest' and 'quay.io/fedora/ruby-33:fedora' and 'quay.io/fedora/ruby-33:20240516-acc810b'
Error: normalizing name "quay.io/fedora/ruby-33:": normalizing name "quay.io/fedora/ruby-33:": invalid reference format

We need to change this row https://github.com/sclorg/container-common-scripts/blob/master/tag.sh#L35 in case we want to setup VERSION to unset. It is used in labels here: https://github.com/sclorg/s2i-ruby-container/blob/master/3.3/Dockerfile.fedora#L28

phracek commented 6 months ago

[test-all]

jackorp commented 6 months ago

Can't see anything weird that would hit me in the eyes. LGTM. Thanks.

phracek commented 6 months ago

[test-openshift]

phracek commented 6 months ago

Please try to avoid commit messages like "Update imagestreams/ruby-rhel-aarch64.json". They do not add much value to the commit.

Otherwise LGTM.

This is a message from commit suggestions as soon as I approve.

zmiklank commented 6 months ago

This is a message from commit suggestions as soon as I approve.

It can be changed before approving and commiting.