sclorg / s2i-ruby-container

Ruby container images based on Red Hat Software Collections and intended for OpenShift and general usage, that provide a platform for building and running Ruby applications. Users can choose between Red Hat Enterprise Linux, Fedora, and CentOS based images.
http://softwarecollections.org
Apache License 2.0
55 stars 156 forks source link

Add build and push image to quay.io/fedora/ruby-33 repository #548

Closed phracek closed 4 months ago

phracek commented 5 months ago

This pull request adds GitHub action for building and pushing each Fedora ruby container into quay.io/fedora/ruby-{version} registry

phracek commented 5 months ago

[test-all]

phracek commented 5 months ago

@jackorp PTAL. Let's build and push Fedora ruby-containers into quay.io/fedora/ruby-{version} registries.

jackorp commented 5 months ago

My eyes don't see anything else that would seem out of place or weird, so rest is LGTM.

pvalena commented 5 months ago

What about the test suite failures?

pvalena commented 5 months ago
Installing sass-rails 6.0.0
Gem::Ext::BuildError: ERROR: Failed to build gem native extension.

current directory:
/opt/app-root/src/bundle/ruby/3.3.0/gems/sqlite3-1.4.4/ext/sqlite3
jackorp commented 5 months ago

What about the test suite failures?

Fedora Ruby 3.3 is failing on compiling the gems for some time now. It might be that an update of some app's gems are needed due to some changes or updates in compiler on Fedora.

I haven't had time to properly investigate it yet.

phracek commented 5 months ago

There was a bit outage of OpenShift cluster. re-running tests and let's see.

phracek commented 4 months ago

Ruby-3.3 tests on Fedora are reported here: https://github.com/sclorg/s2i-ruby-container/issues/550

jackorp commented 4 months ago

@phracek https://github.com/sclorg/rails-ex/pull/173 to fix the Fedora Ruby 3.3 was merged, please re-run the tests.

phracek commented 4 months ago

[test]

jackorp commented 4 months ago

Looks like Fedora Ruby 3.3 passed, but there is still failing gem build (Search for line An error occurred while installing nio4r (2.5.7), and Bundler cannot continue., which is at the end of failed installation), but it doesn't lead to failed CI or a failed test, so I am quite confused what source is being used there (it is not the rails-ex app).

JFTR, it seems like the same class of issue as sqlite3 so some app probably needs dependency adjustment, I just am not sure which one. Could we add a log line into tests that would say what is URL (with branch ideally) of a cloned app or if it is some "app" local to this repo, which source it is actually using?

Also the question is how come the test passes when the build of the container for test seems to fail?

phracek commented 4 months ago

Looks like Fedora Ruby 3.3 passed, but there is still failing gem build (Search for line An error occurred while installing nio4r (2.5.7), and Bundler cannot continue., which is at the end of failed installation), but it doesn't lead to failed CI or a failed test, so I am quite confused what source is being used there (it is not the rails-ex app).

JFTR, it seems like the same class of issue as sqlite3 so some app probably needs dependency adjustment, I just am not sure which one. Could we add a log line into tests that would say what is URL (with branch ideally) of a cloned app or if it is some "app" local to this repo, which source it is actually using?

Also the question is how come the test passes when the build of the container for test seems to fail?

I will look at it. It seems like it is not related to OpenShift 4. I prefer to file an issue with the error and fix it later on, so we do not block this issue. WDYT?

jackorp commented 4 months ago

I prefer to file an issue with the error and fix it later on, so we do not block this issue. WDYT?

Sounds good to me.

phracek commented 4 months ago

@jackorp I checked the logs for Fedora 3.3 and rails-ex is not used. It is used only in test case 'test_from_dockerfile'. I guess, the failure should be caused by different an issue. The test case that failed is 'test_npm_functionality'

jackorp commented 4 months ago

I prefer to file an issue with the error and fix it later on,

I have created #554

phracek commented 4 months ago

I guess, this can be merged, right?

jackorp commented 4 months ago

Yes, I'd say we can go ahead with this.