search

sclorg / spec2scl

MIT License
7 stars 7 forks source link

Issues using `spec2scl --meta-specfile` on copr #33

Open ibotty opened 7 years ago

ibotty commented 7 years ago

It was necessary to use this pull request, i.e. this partial patch:

-%scl_package %scl
+%{?scl_package:%scl_package %scl}
 [...]
-Name: %scl_name
+Name: %scl

Is that correct? If so, I can provide a patch (afaict it's only necessary to change it in templates/metapackage.spec).

irushchyshyn commented 7 years ago

spec2scl follows the recommendations and examples documented in the SCL packaging guide, therefore I am reluctant to do this change here. And in your example, should not Name be changed to something like Name: %{?scl_name}%{!?scl_name:%scl}?

ibotty commented 7 years ago

I have absolutely no clue, and that's the first scl I am building.

Having said that, copr folks said, that the patch above is what's required to build on copr. Your change is of course more reasonable (and will make it work for copr and be as before whenever scl_name is defined). I'd really like to understand what's happening here. What's %scl_name vs %scl? If the meta package is to be installed without scl-utils-build, why does it use the %scl_package macro?