Closed LecrisUT closed 2 months ago
Hi.
I would say this approach is not the only one, or even default one that the user of tfaga can choose.
We, in sclorg, do not set in our tfaga workflows git_url
or git_ref
based on information from cloned repository. We have tmt plans stored separately.
So that would require adding another input for setting if we want to use git_ref
and git_url
from current repo. In my opinion is therefore more efficient to use explicitly the inputs we already have.
Please correct me, if otherwise.
What I was meaning to suggest is defaults, i.e. default all the values to either ${{ github.ref }}
(if possible) or default them to empty and within the JS code, if they are empty fill in the defaults from the action-toolkit. This would not impact other users, but it would make the first-party user (one with tmt tree in the upstream repo) have less to research on how to set it up for push, pull, etc.
Oh, sure, I understand now, thanks.
There are variables like
${{ github.ref }}
/$GITHUB_REF
(and more specific ones within action toolkit) to automatically extract the git repo.Preferably it should use the results from
actions/checkout
, but that may be difficult given the currenttesting-farm
api :/