search

sclorg / testing-farm-as-github-action

GitHub Action to execute tests by Testing Farm and update Pull Request status
MIT License
13 stars 11 forks source link

This issue adds plan-filter into TFaGA #223

Closed phracek closed 1 month ago

phracek commented 1 month ago

Add plan-filter into TFaGA

Closes: #222

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.36%. Comparing base (56b033b) to head (9f61ef1).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #223 +/- ## ========================================== + Coverage 93.27% 93.36% +0.08% ========================================== Files 11 11 Lines 595 603 +8 Branches 112 114 +2 ========================================== + Hits 555 563 +8 Misses 40 40 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

phracek commented 1 month ago

[test]

phracek commented 1 month ago

[test]

spetrosi commented 1 month ago

One question, tmt allows for providing several tags with the filter like tmt plans ls --filter "tag:mssql,general,postfix". Will that work with tmt_plan_filter too? I guess if I set tmt_plan_filter: "tag:mssql,general,postfix".

phracek commented 1 month ago

One question, tmt allows for providing several tags with the filter like tmt plans ls --filter "tag:mssql,general,postfix". Will that work with tmt_plan_filter too? I guess if I set tmt_plan_filter: "tag:mssql,general,postfix".

@spetrosi Well as an input we get string, so If you enter string, like you want, we send it to Testing Farm. As soon as this pull request is merged into main, can you please test it and provide a feedback. Thanks

phracek commented 1 month ago

@spetrosi Can you please past link to your plans for an inspiration?

spetrosi commented 1 month ago

They are not ready yet, so far I am using a single plan in https://github.com/linux-system-roles/tft-tests/tree/main/plans. For testing how tmt filters, I copied this plan and applied different tags to each copy. BTW tmt also supports setting several tags which is good.

spetrosi commented 2 weeks ago

@phracek I am running TFaGA with tmt_plan_filter: "tag:general,postfix", the workflow returns a warning:

Warning: Unexpected input(s) 'tmt_plan_filter', valid inputs are ['api_key', 'api_url', 'tf_scope', 'git_url', 'git_ref', 'tmt_plan_regex', 'tmt_context', 'tmt_path', 'compose', 'arch', 'variables', 'secrets', 'tmt_hardware', 'copr', 'copr_artifacts', 'github_token', 'create_issue_comment', 'pull_request_status_name', 'update_pull_request_status', 'environment_settings', 'pipeline_settings', 'create_github_summary', 'timeout', 'repo_owner', 'repo_name', 'pr_number', 'commit_sha'] It's in https://github.com/spetrosi/postfix/actions/runs/10561612203/job/29257740325