scm-manager / scm-redmine-plugin

Integrates Redmine to SCM-Manager
MIT License
0 stars 1 forks source link

Allow duplicate mapping entries #29

Closed fscholdei closed 3 years ago

fscholdei commented 3 years ago

Proposed changes

Allow duplicate mapping entries, enrich table labeling

Your checklist for this pull request

Contributor:

Reviewer:

Checklist for branch merge request (not required for forks)

eheimbuch commented 3 years ago

Well, you fixed the frontend with this. But what about REST? If the frontend merges the entries now i could assume that this happens in general. But if try it out with cURL my last keyword-mapping entry wins.

Example:

curl -X 'PUT' \
  'http://localhost:8081/scm/api/v2/redmine/configuration/scmadmin/a' \
  -H 'accept: */*' \
  -H 'Authorization: Basic c2NtYWRtaW46c2NtYWRtaW4=' \
  -H 'Content-Type: application/json' \
  -d '{
  "url": "",
  "textFormatting": "TEXTILE",
  "autoClose": true,
  "updateIssues": true,
  "username": "",
  "password": "",
  "keywordMapping": {
    "a": "b,b,c",
    "a": "b",
    "a": "b,b,d"
  }
}'