search

scm-spain / boros-CMP

GDPR CMP (Consent Managment Provider) implementation
MIT License
5 stars 1 forks source link

Remove the default remote URL for global storage iframe #28

Closed alextremp closed 6 years ago

alextremp commented 6 years ago

This PR:

The iframe's content HTML URL is mandatory when the global consent storage is set up to be true

alextremp commented 6 years ago

@victuxbb you can review again with the commented change

codecov-io commented 6 years ago

Codecov Report

Merging #28 into feature/develop-v1.0.0 will increase coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@                    Coverage Diff                     @@
##           feature/develop-v1.0.0      #28      +/-   ##
==========================================================
+ Coverage                   96.53%   96.53%   +<.01%     
==========================================================
  Files                          30       30              
  Lines                        1241     1242       +1     
  Branches                      108      108              
==========================================================
+ Hits                         1198     1199       +1     
  Misses                         43       43
Impacted Files Coverage Δ
src/cmp/infrastructure/configuration/defaults.js 100% <ø> (ø) :arrow_up:
.../cmp/infrastructure/configuration/Configuration.js 100% <100%> (ø) :arrow_up:
src/cmp/infrastructure/service/IframeRegistry.js 95.45% <100%> (+0.21%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4f05707...13a2455. Read the comment docs.