scm-spain / boros-CMP

GDPR CMP (Consent Managment Provider) implementation
MIT License
5 stars 1 forks source link

Test folder #30

Closed victuxbb closed 6 years ago

victuxbb commented 6 years ago
codecov-io commented 6 years ago

Codecov Report

Merging #30 into feature/IframeRepository will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@                    Coverage Diff                    @@
##           feature/IframeRepository      #30   +/-   ##
=========================================================
  Coverage                     97.16%   97.16%           
=========================================================
  Files                            49       49           
  Lines                          1799     1799           
  Branches                        145      145           
=========================================================
  Hits                           1748     1748           
  Misses                           51       51

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4df5f3b...3cd5d7d. Read the comment docs.

victuxbb commented 6 years ago

Yes, we will have "src/test/cmp" and that's the idea and in this project is the perfect example of why is this a good option.

For example if you pick up any random project of our company in general you will find this structure forlder: https://github.schibsted.io/scmspain/ms-common--locations/tree/master/src And you can see that there is a test folder and inside is the repeated app package.

In summary, you should ask yourself, are tests source code?

BTW, OpenAds is already using this structure ;) https://github.com/scm-spain/OpenAds/tree/master/src