scm-spain / boros-CMP

GDPR CMP (Consent Managment Provider) implementation
MIT License
5 stars 1 forks source link

Hotfix/global vendor list version update is not saving a new consent #44

Closed alextremp closed 6 years ago

alextremp commented 6 years ago

Check the changes in ConsentFactory

codecov-io commented 6 years ago

Codecov Report

Merging #44 into feature/develop-v1.0.0 will increase coverage by 0.43%. The diff coverage is 97.93%.

Impacted file tree graph

@@                    Coverage Diff                     @@
##           feature/develop-v1.0.0      #44      +/-   ##
==========================================================
+ Coverage                   96.69%   97.13%   +0.43%     
==========================================================
  Files                          59       59              
  Lines                        2178     2161      -17     
  Branches                      171      169       -2     
==========================================================
- Hits                         2106     2099       -7     
+ Misses                         72       62      -10
Impacted Files Coverage Δ
...ructure/container/global/GlobalConsentContainer.js 100% <ø> (ø) :arrow_up:
...structure/container/local/LocalConsentContainer.js 100% <100%> (ø) :arrow_up:
...frastructure/repository/CookieConsentRepository.js 100% <100%> (ø) :arrow_up:
...r/globalVendorListVersionChangedObserverFactory.js 100% <100%> (+57.14%) :arrow_up:
...frastructure/repository/IframeConsentRepository.js 100% <100%> (ø) :arrow_up:
src/cmp/domain/consent/ConsentFactory.js 100% <100%> (ø) :arrow_up:
...p/infrastructure/container/BaseConsentContainer.js 84.32% <80%> (+8.57%) :arrow_up:
.../cmp/domain/consent/UpdateConsentVendorsService.js 94.68% <97.05%> (-5.32%) :arrow_down:
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c085c26...a2bf98a. Read the comment docs.