search

scm-spain / boros-CMP

GDPR CMP (Consent Managment Provider) implementation
MIT License
5 stars 1 forks source link

Refactor and Log fix #45

Closed victuxbb closed 6 years ago

victuxbb commented 6 years ago

Keep in mind that we must refactor the domain, so the service UpdateConsentVendorsService will desapear and all this business will be inside a domain entity. Being said that, just for now, the service is only used inside the observer of globalVendorListChanged so checking again if version is changed is not necessary.

codecov-io commented 6 years ago

Codecov Report

Merging #45 into hotfix/global-vendor-list-version-update-is-not-saving-a-new-consent will decrease coverage by 0.04%. The diff coverage is 100%.

Impacted file tree graph

@@                                           Coverage Diff                                            @@
##           hotfix/global-vendor-list-version-update-is-not-saving-a-new-consent      #45      +/-   ##
========================================================================================================
- Coverage                                                                 97.17%   97.12%   -0.05%     
========================================================================================================
  Files                                                                        59       59              
  Lines                                                                      2158     2160       +2     
  Branches                                                                    170      169       -1     
========================================================================================================
+ Hits                                                                       2097     2098       +1     
- Misses                                                                       61       62       +1
Impacted Files Coverage Δ
.../cmp/domain/consent/UpdateConsentVendorsService.js 94.68% <100%> (-0.98%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 72d2743...6d9ffe2. Read the comment docs.