search

scm-spain / boros-CMP

GDPR CMP (Consent Managment Provider) implementation
MIT License
5 stars 1 forks source link

Feature/same site cookie lax #74

Closed maryammdot closed 4 years ago

maryammdot commented 4 years ago

Description

With the update of the treatment of the cookies in several browsers, the field sameSite should be informed in euconsent cookie

Solves ticket/s

https://jira.scmspain.com/browse/PSP-2867

Expected behavior

When cmp is working on local version the cookie should have sameSite = lax value. When working in global mode it should have sameSite = none and Secure attributes.

Review steps

Compile boros and initialize it (local mode and global mode - follow the readme). Check the cookie in the devTools. image

Further considerations

When initializing boros in global mode, the comunication with local servers is http so the cookie is not accepting the Secure attribute (on production it has to be https, in that case the attribute will be accepted) image

Memetized description

mandatory

maryammdot commented 4 years ago

you are right, I will put the capital letter in uppercase

codecov-io commented 4 years ago

Codecov Report

Merging #74 into master will decrease coverage by 0.19%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #74     +/-   ##
=========================================
- Coverage   92.48%   92.28%   -0.2%     
=========================================
  Files          73       73             
  Lines        2354     2295     -59     
  Branches      160      156      -4     
=========================================
- Hits         2177     2118     -59     
  Misses        177      177
Impacted Files Coverage Δ
...tructure/repository/ChainedVendorListRepository.js 100% <100%> (ø) :arrow_up:
.../repository/HttpTranslationVendorListRepository.js 100% <100%> (ø) :arrow_up:
...rastructure/repository/HttpVendorListRepository.js 100% <100%> (ø) :arrow_up:
src/cmp/domain/vendor_consents/VendorConsents.js 86.36% <0%> (-5.44%) :arrow_down:
...epository/ConsentStringVendorConsentsRepository.js 98.9% <0%> (+0.62%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 54b22ee...27173fd. Read the comment docs.