search

scm-spain / boros-CMP

GDPR CMP (Consent Managment Provider) implementation
MIT License
5 stars 1 forks source link

Hotfix/latest vendorlist #75

Closed maryammdot closed 4 years ago

maryammdot commented 4 years ago

Description

when asking for the latest version of the vendorList an error occurs.

Solves ticket/s

https://jira.scmspain.com/browse/PSP-2887

Expected behavior

When asking for the latest version, the real petition should be done to /vendorlist.json, without specifying version. With this petition the vendorList returned will be the last one.

Review steps

Charles it and from the window make this petition: 

window.__cmp('getVendorList', 'LATEST', function(data) {console.log('>>>> ', data)})

Check in the network for the petition of the vendor.js and the purposes. image

Memetized description

mandatory

codecov-io commented 4 years ago

Codecov Report

Merging #75 into master will increase coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #75      +/-   ##
==========================================
+ Coverage   94.11%   94.12%   +<.01%     
==========================================
  Files          73       73              
  Lines        2278     2279       +1     
  Branches      156      156              
==========================================
+ Hits         2144     2145       +1     
  Misses        134      134
Impacted Files Coverage Δ
.../repository/HttpTranslationVendorListRepository.js 100% <100%> (ø) :arrow_up:
...rastructure/repository/HttpVendorListRepository.js 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fddf08f...cb83822. Read the comment docs.