search

scmbreeze / scm_breeze

Adds numbered shortcuts to the output git status, and much more
https://madebynathan.com/2011/10/19/git-shortcuts-like-youve-never-seen-before/
MIT License
2.82k stars 192 forks source link

Swapping the commands check #210

Closed masonlouchart closed 7 years ago

masonlouchart commented 7 years ago

This commit swaps the two exports of the commands "hub" and "gh" in the aliases. The fact is the export of "gh" overwrites the previous one, and the official GitHub client is using "hub" as command.

See https://github.com/github/hub/issues/475. Closes #209

masonlouchart commented 7 years ago

NOTE

The script shell should check the availability of the both commands to define which of them must be exported. To be honest, I don't have the skills to do this. But, the original repo is born 2 years ago. I hope everyone has upgraded its library with the official GitHub client which is using hub as command (and not gh). So we could even remove the export of the gh command.

fbvilela commented 7 years ago

Confirmed the issue after updating oh-my-zsh @LM450N, nice catch!

But checking out your fork didn't fix it for me... I'm on MAC OS

masonlouchart commented 7 years ago

During my sleep I was thinking about this PR. I think it shouldn't be accepted. It's not a universal and clear solution. The issue probably comes from an other place (but still from oh-my-zsh).