search

scmbreeze / scm_breeze

Adds numbered shortcuts to the output git status, and much more
https://madebynathan.com/2011/10/19/git-shortcuts-like-youve-never-seen-before/
MIT License
2.82k stars 191 forks source link

install script messes with my `.zshrc` #219

Open vise890 opened 7 years ago

vise890 commented 7 years ago

I'd rather have the modification of .bashrc/.zshrc left to the user rather than the magical install.sh (and the added complexity of checking if the string is already present). Any thoughts?

vise890 commented 7 years ago

it also messes with my .bashrc / .bash_profile . Sneakily!

ghthor commented 7 years ago

I agree, we should cut it out and provide it as a separate script.

vise890 commented 7 years ago

So would these be acceptable installation instructions? 

git clone git://github.com/scmbreeze/scm_breeze.git ~/.scm_breeze
~/.scm_breeze/install.sh # creates alias config files (e.g. ~/.git.scmbrc, ~/.scmbrc) (do we even need these? can these be the defaults?)
echo 'source "$HOME/.scm_breeze/scm_breeze.sh"' >> ~/.bashrc
source ~/.bashrc

I'd be in favour of skipping the install script entirely, just use the current aliases as defaults; then we could just have:

git clone git://github.com/scmbreeze/scm_breeze.git ~/.scm_breeze
echo 'source "$HOME/.scm_breeze/scm_breeze.sh"' >> ~/.bashrc
source ~/.bashrc

No magic!

vise890 commented 7 years ago

@g5pw you know you want to do this 👅

g5pw commented 7 years ago

I was summoned :D what should I do? PR to update the README? I'm also in favor of killing install.sh.

vise890 commented 7 years ago

so .. yes, however i still think we should copy over the *.scmbrc files (as per https://github.com/scmbreeze/scm_breeze/blob/master/install.sh#L32).

So maybe just strip down install.sh to that line only for now and update the readme?