search

scmbreeze / scm_breeze

Adds numbered shortcuts to the output git status, and much more
https://madebynathan.com/2011/10/19/git-shortcuts-like-youve-never-seen-before/
MIT License
2.82k stars 192 forks source link

`.git.scmbrc` shoulud not be needed if using default aliases #235

Open vise890 opened 7 years ago

vise890 commented 7 years ago

The built in aliases are great so I never had the need touch my ~/.git.scmbrc I'm not against having one, but could we not just:

if [ -f ~/.git.scmbrc ]; then
  source ~/.git.scmbrc
else
  source ~/.scm_breeze/.git.scmbrc.example
fi

? this, together with #219 would remove the need for an install.sh script entirely

g5pw commented 7 years ago

Yeah, that seems more sensible to me. We could even do

source ~/.scm_breeze/.git.scmbrc.example
if [ -f ~/.git.scmbrc ]; then
  source ~/.git.scmbrc
fi

so one can have a compact .git.scmbrc by setting just the values that deviate from the defaults.

vise890 commented 7 years ago

yea, the only downside to loading the built in regardless is that someone may not want some aliases? Is that a problem?

ghthor commented 7 years ago

Yeah, it should be either or, not one over the other.

On Wed, Feb 15, 2017 at 6:36 AM, Martino Visintin notifications@github.com wrote:

yea, the only downside to loading the built in regardless is that someone may not want some aliases? Is that a problem?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/scmbreeze/scm_breeze/issues/235#issuecomment-279988341, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJyKsr-xoBSU_MhozKNCtDfBnbSWlQZks5rcuNCgaJpZM4MA5GV .