search

scmbreeze / scm_breeze

Adds numbered shortcuts to the output git status, and much more
https://madebynathan.com/2011/10/19/git-shortcuts-like-youve-never-seen-before/
MIT License
2.82k stars 192 forks source link

Remove "--" from end of aliases #253

Closed HaleTom closed 5 years ago

HaleTom commented 5 years ago

Fix #252

ghthor commented 5 years ago

I'm not sold on this change. When I need this functionality I just type out g reset --soft. The short alias is intended to work with the [1]..[N] aliases and I think this changes that behavior?

If it doesn't and I can still use grs 1-3 then I suppose this change is ok.

On Sat, Aug 18, 2018, 06:14 Tom Hale notifications@github.com wrote:

You can view, comment on, or merge this pull request online at:

https://github.com/scmbreeze/scm_breeze/pull/253 Commit Summary

  • Remove -- from end of aliases

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/scmbreeze/scm_breeze/pull/253, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJyKv7fnSJkd0UtvbwIh6_esuuLDLSoks5uR-kigaJpZM4WCg_4 .

HaleTom commented 5 years ago

@ghthor this will still enable the use case you show. I've tested with:

ge git reset 1-2

It behaves as expected: unadding the first two files.

On the very rare occasion you really need the -- you can manually add it yourself anyway.

ghthor commented 5 years ago

Awesome, Thanks for testing this!